Thread: Kirsch
View Single Post
  #18  
Old 04-18-2008, 12:34 AM
cheesegrits's Avatar
cheesegrits cheesegrits is offline
 
Join Date: May 2006
Posts: 500
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Yarub,

Thanks for keeping Kirsch alive. I've been a happy Kirsch user since 3.5, and am very glad you continue to put in the time and effort to keep it updated.

A couple of small XHTML issues, not serious, but they do cause validation errors (using the standard W3 Validator):

In 'header', the ...

HTML Code:
<td align="top">
... needs to be ...

HTML Code:
<td valign="top">
And in 'footer', the ...

HTML Code:
</td>
</tr>
</table>
... that terminates the main content table opened in 'header' needs to be moved down to the bottom of the template, otherwise it causes 'unterminated tag' issues with the footer form and table.

EDIT - turns out that making the above change, although the page then passes XHTML validation, it breaks the user profile tabs in IE. Works fine in FF. Wanting the best of both worlds, I just removed that surrounding td entirely, and terminated the table in the header instead, like the default vB template. Tabs work, page looks the same, passes validation.


Oh, and a few of missing images from the new 3.7 Profile pages:

buttons/collapse_generic.gif
buttons/collapse_generic_collapsed.gif
buttons/upload_pictures.png
misc/menu_open_usercss.gif
misc/unknown.gif
misc/userfield_edit.gif

-- hugh
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01202 seconds
  • Memory Usage 1,767KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_html
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete