[sweede]

Originally Posted by hinch

the crit change isn't so obvious as in your code you have all spell crits split off separately what i'm proposing is merging them all so they're not split off anymore since for warlocks and I assume mage's too etc your crit chance with one damage type is teh same as the other damage type excluding talents (since armoury excludes talents anyway)

<critChance rating="285">
          <arcane percent="23.34"/>
          <fire percent="32.34"/>
          <frost percent="23.34"/>
          <holy percent="23.34"/>
          <nature percent="23.34"/>
          <shadow percent="23.34"/>
</critChance>

Taken from a firemage's armory.

In the future, the crit chance returned will be based on the characters spec, which would govern their primary nuke. You will also have the option to display the max crit rate and all schools individual crit rates.