vb.org Archive - View Single Post - What's the best way to remove a corrupted mod?

#3 02-15-2008, 09:40 PM

I don't want to point the finger at Abe's code, because obviously it's a very popular hack that's working well on a ton of sites. I can only say what happened to me personally when I tried to uninstall the old version after I upgraded to 3.7. I see this uninstall code in the XML:

Code:

 <installcode>
- <![CDATA[ 
$db->hide_errors();

$vbulletin->db->query_write("CREATE TABLE IF NOT EXISTS`". TABLE_PREFIX ."post_thanks` (
    `id` INT(10) NOT NULL AUTO_INCREMENT PRIMARY KEY,
    `userid` INT(10) NOT NULL,
    `username` VARCHAR(50) NOT NULL,
    `date` INT(10) NOT NULL,
    `postid` INT(10) NOT NULL)
    ");
$vbulletin->db->query_write("ALTER TABLE `". TABLE_PREFIX ."post_thanks` ADD INDEX ( `postid` )");

$vbulletin->db->query_write("ALTER TABLE `". TABLE_PREFIX ."user` ADD `post_thanks_user_amount` INT( 10 ) UNSIGNED DEFAULT '0' NOT NULL");
$vbulletin->db->query_write("ALTER TABLE `". TABLE_PREFIX ."post` ADD `post_thanks_amount` INT( 10 ) UNSIGNED DEFAULT '0' NOT NULL");
$vbulletin->db->query_write("ALTER TABLE `". TABLE_PREFIX ."user` ADD `post_thanks_thanked_posts` INT( 10 ) UNSIGNED DEFAULT '0' NOT NULL");
$vbulletin->db->query_write("ALTER TABLE `". TABLE_PREFIX ."user` ADD `post_thanks_thanked_times` INT( 10 ) UNSIGNED DEFAULT '0' NOT NULL");

$db->show_errors();

  ]]> 
  </installcode>
- <uninstallcode>
- <![CDATA[ 
$db->hide_errors();

$vbulletin->db->query_write("DROP TABLE IF EXISTS " . TABLE_PREFIX . "post_thanks");
$vbulletin->db->query_write("ALTER TABLE `". TABLE_PREFIX ."user` DROP `post_thanks_user_amount`");
$vbulletin->db->query_write("ALTER TABLE `". TABLE_PREFIX ."post` DROP `post_thanks_amount`");
$vbulletin->db->query_write("ALTER TABLE `". TABLE_PREFIX ."user` DROP `post_thanks_thanked_posts`");
$vbulletin->db->query_write("ALTER TABLE `". TABLE_PREFIX ."user` DROP `post_thanks_thanked_times`");

$db->show_errors();

  ]]> 
  </uninstallcode>

And I think those alter statements are probably part of what's causing my headaches. I've tried uninstalling it cleanly, as well as just installing the new one and letting it overwrite and both yield me the same issue of a hosed post table. My only advice is to definitely back up your forums before trying it.

I'm gong to be a smart puppy this weekend and just port my entire 3.7 install over to my testbed and try to sort it out there before trying anything on my live site, but at the time I didn't expect such a big crash from something as small as uninstalling a plugin. Live and learn I guess.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01269 seconds Memory Usage 1,769KB Queries Executed 11 (?)
More Information
Template Usage: (1)SHOWTHREAD_SHOWPOST (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)bbcode_code (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_box (1)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (1)post_thanks_postbit_info (1)postbit (1)postbit_wrapper (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit reputationlevel showthread	Included Files: ./showpost.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_postinfo_query fetch_postinfo fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showpost_start bbcode_fetch_tags bbcode_create postbit_factory showpost_post postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start showpost_complete
Messages: