View Single Post
  #8  
Old 02-05-2008, 07:44 AM
VBDev's Avatar
VBDev VBDev is offline
 
Join Date: Jan 2004
Location: France
Posts: 2,570
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

To diminish queries, you could perhaps try it like that :

PHP Code:
$charinsqa 'INSERT INTO userskills (characterid) VALUES ';
$insert '';
/* Check if users exist */
$existquerya  'SELECT characterid FROM userskills WHERE characterid IN(' implode(',',$charid). ')';
$existresulta  mysql_query($existresulta); 
/* Removing elements from $charid if retrieved from database */
if (mysql_num_rows($existresulta))
{
 
/* Fetch request result */
 
while($row mysql_fetch_array($existresulta))
 {
  
/* Search if element is in $charid */
  
$position array_search($row['characterid'],$charid);
  
  
/* Found */
  
if ($position)
  {
   unset(
$charid["$position"]);
  }
 }
}
/* At this point $charid contains only new values or is empty, let's build the insert */
if ($charid)
{
 for (
$i 0$i sizeof($charid); $i++)
 {
  
/* Coma needed only after the first value */
  
if ($i != 0)
  {
   
$insert .= ',';
  }
  
  
$insert .= '("'.$charid[$i].'")'
 }
 
 
/* Let's insert new values in one query into the database */
 
$charinsqab $charinsqa $insert;
 
mysql_query($charinsqab) or die('Insert failed: '.mysql_error()); 
}

unset(
$charinsqa);
unset(
$charinsqab); 
I have not tested it and not sure there are no errors, but with this code you would have only one select and one insert
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02823 seconds
  • Memory Usage 1,779KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_php
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete