vb.org Archive - View Single Post

Opserty · #6 11-23-2007, 03:53 PM

Make a new template? Like imagewtf_noframes and then check if they have frames or something?

I think you may be going about it the wrong way. Heres the way I would have done it.

PHP Code:


			
// START OF MAIN SCRIPT

$db->query(// Query for settings
if($uploadactive == true) // Or however you plan on checking it
{
    if(...) // Check if in correct usergroup
        {
            eval('$innertemp = "'. fetch_template('imagewtf_frame') .'";');
    }
}

// NOW WE CALL THE SHELL TEMPLATE

eval('print_output("'. fetch_template('imagewtf_shell') .'");');

Example template imagewtf_frame:

Code:

    We have our content here

Example template imagewtf_shell:

Code:

<html>
<head....

...body>

We have our standard content here, which is displayed regardless of usergroup or if modification is active

$innerhtml
</body>
</html>

Notice the $innerhtml variable, now if the modification is not active or the user is not in the required usergroup then $innerhtml will be empty and therefore will not appear. I don't see why you need to use frames unless you are trying to achieve something else.

Also some general pointers.

You can store settings in vBulletin Options (Enter debug mode then navigate to your options). If you add them to vBulletin options then you can access by using $vbulletin->options['....'] instead of performing a number of queries just to obtain settings for your modification.
If you are querying for just a single piece of data from MySQL use the $db->query_first(...) database function, it will reduce the lines of code you need significantly. For example:

PHP Code:

$settings = $db->query_first("SELECT * FROM imagewtf_settings WHERE settingname='allowedusergroups' LIMIT 1"); // No need for this line: $settings = $db->query_read($query); // No need for this line: $setting = $db->fetch_array($settings); $set = $setting['switch2'];
Use the is_member_of($userinfo, $usergroups); function as this checks both primary and secondary usergroups.

PHP Code:

// $allowedug = explode(",", $set); // if(in_array ( $usergroupid, $allowedug )) // ------------- NOW BECOMES --------------- $allowedug = exmplode(',', $set); if(is_member_of($vbulletin->userinfo, $allowedug)) { //...

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01128 seconds Memory Usage 1,785KB Queries Executed 11 (?)
More Information
Template Usage: (1)SHOWTHREAD_SHOWPOST (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code (3)bbcode_php (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_box (1)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (1)post_thanks_postbit_info (1)postbit (1)postbit_onlinestatus (1)postbit_wrapper (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit reputationlevel showthread	Included Files: ./showpost.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_postinfo_query fetch_postinfo fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showpost_start bbcode_fetch_tags bbcode_create postbit_factory showpost_post postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start showpost_complete
Messages: