Bryan, giving out your vbulletin customer details is pretty stupid to be blunt. As is giving out your Ftp details for no real reason, 90% of modifications don't require file uploads, the most he needs is administrative access to your plugins, which I wouldn't trust a random stranger to do anyway.
Theres alot of people around that take advantage of people, just be careful who you give your info to.