View Single Post
  #1  
Old 09-07-2007, 02:03 PM
Opserty Opserty is offline
 
Join Date: Apr 2007
Posts: 4,103
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default [JS] There must be a better way to do this

Ok a little background info first. Basically put we have added a couple of AJAX menus to our postbit template to enable our moderators to hand out warns and bans quickly without the need to leave the page. I basically hacked together a bit of Javascript which I found using good old google. However I'm almost certain there is a better way to do what we are doing because at the moment we have to output a whole javascript function (shown below) for each post.

HTML Code:
<script type="text/javascript">
    // JavaScript Document
    function sendWarnData1242913(frmName, divID)
    {
        var XMLHttpRequestObject = false;
        if (window.XMLHttpRequest)
        {
            XMLHttpRequestObject = new XMLHttpRequest();
        }
        else if (window.ActivexObject) 
        {
            XMLHttpRequestObject = new ActiveXObject("Microsoft.XMLHTTP");
        }
        var url = 'showthread.php?do=XXXX';
        var obj = document.getElementById(divID);
        var frm = frmName;
        
        if(XMLHttpRequestObject) 
        {
            XMLHttpRequestObject.open("POST", url); 
            XMLHttpRequestObject.setRequestHeader('Content-Type','application/x-www-form-urlencoded'); 
            XMLHttpRequestObject.send("post=" + frm.post.value + "&id=" + frm.id.value + "&alert=" + frm.alert.value + "&warningid=" + frm.warningid.value + "&comment=" + frm.comment.value); 

            obj.innerHTML =  "<img src='images/ajaxloading.gif' alt='Loading' />" ;
            XMLHttpRequestObject.onreadystatechange = function() 
            { 
                if (XMLHttpRequestObject.readyState == 4 && XMLHttpRequestObject.status == 200) 
                {
                    obj.innerHTML = XMLHttpRequestObject.responseText;
                } 
            } 
            
            
        }
    }
</script>
Our form looks something like this:
HTML Code:
<form action="#" method="post" id="opwarnform1242913" id="opwarnform1242913" name="opwarnform">
    <input type="hidden" id="post" name="post" value="1242913" />
    <input type="hidden" id="id" name="id" value="7198" />
    <input type="hidden" id="alert" name="alert" value="" />
    Warning Type: <br />
    <select name="warningid">

        <option value="1">Wrong Forum</option><option value="8">Double Posted</option><option value="9">Other</option><option value="10">URL in Topic Title</option><option value="18">Not meeting Sig request requirements</option><option value="13">Failed to give constructive criticism</option><option value="17">Marketplace Negative Comment</option><option value="6">Offensive word / phrase</option><option value="11">Affiliate Referral Links</option><option value="4">Warez</option><option value="20">Spamming</option><option value="2">Flaming</option><option value="7">Unfound Ripper Accusation</option>
    </select> <br /><br />

    Comment:<br />
    <input type="text" id="comment" value="" class="smallfont" name="comment" /><br /><br />
    <input style="padding:1px;" type="button" onclick="sendWarnData1242913(this.form, 'warndiv1242913')" class="button" value="Warn" />
</form>
I tried merely sending the request via a single function, however I found that it is not possible to 'reset' the result and therefore it is not possible to warn more then once on a page. Maybe I am doing something wrong?

P.S. I'm not a big JS user so don't rip my head off, please.

Thanks in advanced.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01784 seconds
  • Memory Usage 1,784KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_html
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete