[Surviver]

Originally Posted by Gray Matter

This is a great hack, but the templates that go along with it have some slight design issues inside them and (in my opinion) are not visually appealing at all.

I have a few questions:

1. Why does the username of the thread starter appear two times in the edit_history_view template? This is redundant. The second username should be the username of the post creator.
2. What is the variable #$i? I cannot figure out what this is, as it is just displaying a useless number...
3. What conditions must be met in order to show the compare link? I can't find any way to configure it.
4. Why are there colspan="2" attributes on everything in the editbit template? These aren't necessary as there are only three columns in the table, and there are three columns in every row...
5. What is the purpose of the CSS in the edit_history_view template?

and a few suggestions:

1. Add a conditional so that if there is no post title, the "" won't display in the phrase "Edithistory of post "X" in thread "Y." This makes the text ridiculous by showing an unfilled set of quotation marks.
2. When there is no title for the post, the "Post" row will just show a link that says "(Post)." This looks a little redundant, having "Post: (Post)." You should use a conditional to remove the parentheses when there is no post title, and also, I think, change the phrase text to "Show Post."
3. The title row should not show when there are no titles to display.
4. The reason row should not show when there are no reasons to display.
5. The edit time of the post should have a <span class="time"> on it, to keep with vB standards and also to set apart the time itself.
6. Remove the closing </span> tag within the compare conditional. There is no opening tag for this so it shouldn't be there.
7. Why is the phrase "cancle_compare" spelled "cancle?" The proper spelling is "cancel," unless there's some foreign version that I'm unaware of.
8. The "message" text TD should have a valign="top" on it, since it looks a little out of place in the middle of a large post.
9. The last two rows of the editbit table look really unorganized. You should try to configure them differently for a better-looking effect.
10. Sometimes you write "Edit History," and other times as "Edithistory." Why the two versions? You should choose one (may I suggest "Edit History").
11. You have an ampersand that's not encoded in the link of the "Delete All Edits of This Post" link.

Thanks for listening to me rant. Just some constructive criticism.

For anyone who's interested in applying the changes I suggested and removing the unnecessary stuff, I've attached my two templates and two screenshots (one for a post with a title and reason, and one for a post without them) as well. Feel free to use them (They are XHTML 1.0 valid, by the way). Keep in mind that if you use them, you must add two phrases: edithistory_of_post_in_thread_x (Text: Edit History of post in thread "{1}") and show_post (Text: Show Post). Enjoy.

At first thank you for your post!

1.)That seems to be the bug - once it should be the threadstarter and the other should be the postauthor!
2.)Where did you finde it?
3.)You have to set the usergroup permissions. If this does not work, check if the templates are ok.
4.)You're right
5.)This is the CSS for comparing the edits

1.)Noticed for future Versions
2.)Noticed for future Versions
3.)Noticed for future Versions
4.)Noticed for future Versions
5.)Noticed for future Versions
6.)Noticed for future Versions
7.)This happens if i write very fast Maybe i will change this
8.)Noticed for future Versions
9.)The Problem is i'm not a designer I will try to find a better solution
10.)hehe, ok i will use "Edut History" in future
11.)Noticed for future Versions


Thank you for your particural suggestions!
That's nice feedback

Greetings Surviver