Thread: Statistics Modifications - Forum Search Stats V.2
View Single Post
  #45  
Old 08-16-2007, 05:00 PM
coderphp's Avatar
coderphp coderphp is offline
 
Join Date: Nov 2006
Location: Egypt
Posts: 204
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by davide101 View Post
WARNING
Hi, this script is currently NOT safe. A bot searched a dozen times for a malicious phrase and got a javascript redirect to load when the top searches were displayed. Luckily it was just a redirect that can easily be removed. I would disable search logging or fix the software ASAP less someone with a lot more evil intentions starts poking around.
Hello
many thanx for ur interest, but I dont know how you consider this to be Not safe! as tags are removed on listing queries on forumhome,
notice this code snippet, taken from the product:
PHP Code:
if(!in_array(strip_tags($put['query']), $censor_words)) $most_searched .= "<a href=\"search.php?do=process&searchstats=nocount&q="$put['query'] ."\"><font size=\"".$r."\">" strip_tags($put['query']) . "</font></a> &nbsp;&nbsp;"
notcie the function strip_tags (read more about it at php.net/strip_tags)
I see that this is enough to trim any malicious codes, as javascript tags are removed b4 listed on page

to unserstand what im saying please try to search for
Code:
<script, language="javascript">alert('hello');</script>
of course the alert will not appear, if it appears so almost u modified the Mod

thanx for ur interest again, and looking forward to hear from you

Regards
Mahmoud
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01103 seconds
  • Memory Usage 1,777KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code
  • (1)bbcode_php
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete