View Single Post
  #80  
Old 07-05-2007, 11:59 PM
mfyvie mfyvie is offline
 
Join Date: Mar 2007
Location: Zurich, Switzerland
Posts: 336
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Aclikyano View Post
YOU CAN QUICK BAN THE THREAD STARTER.. but you cannot QUICK UNBAN him. (users that are banned)
I think you are reporting an issue which I provided a solution to on post #61. I even wrote the heading in huge bold letters.

Quote:
Originally Posted by Seiyaboy View Post
I sure did. The ban image only appears for membersgroups 9 and under. When the group number is 10 or above, those images do not appear for them. Btw, I use 3.6.7 PL1 of vbulletin. But it's not really a big deal since the trolls are usually just members with 1 to 5 posts. As long as the basic member group can be easily banned, that's good enough for me.
I had a look and found the cause:

Code:
<!-- QUICKBAN BUTTON SHOWED FOR USERGROUPS -->
<if condition="$post[usergroupid]== $vboptions['ugroups_ban']{0} OR $post[usergroupid]== $vboptions['ugroups_ban']{2} OR $post[usergroupid]== $vboptions['ugroups_ban']{4} OR $post[usergroupid]== $vboptions['ugroups_ban']{6} ">
<!-- END QUICKBAN BUTTON SHOWED FOR USERGROUPS -->
See those {0}, {2}, {4} and {6}? The correspond to a character position in a string. So imagine your string is 1,2,3,4 - those character positions would match up. But as soon as you have 10,2,3,4 the whole thing falls apart. because those values will return 1 , , ,

I'll leave you to decide whether you think this was a good idea... I could rewrite this section, but then, given my previous rewrites, that would be almost the last part of the mod which I haven't totally rewritten. Given that this mod is marked as supported but the author hasn't shown up in some time to fix all the problems, I'm not inclined to bother!
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01688 seconds
  • Memory Usage 1,768KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code
  • (2)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete