Thread: Statistics Modifications - Forum Search Stats 1.0
View Single Post
  #118  
Old 07-01-2007, 12:36 PM
cellarius's Avatar
cellarius cellarius is offline
 
Join Date: Aug 2005
Posts: 1,987
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Never mind, fixed it myself. Maybe you should think about changing the code accordingly?

I had to change the code of the "forumhome_complete" plugin. It's this piece of code:
Code:
$r = round($rat*$put['count']);
$most_searched .= "<span dir=\"rtl\"><a href=\"search.php?q=". $put['query'] ."\"><font size=\"".$r."\">" . strip_tags($put['query']) . "</font></a></span>&nbsp;&nbsp;";
I removed the <span>-Tag completely, which solved the problem of the "jumping" keywords when clicked in Firefox and spawned no other issues.

Next problem, which caused the funny line-changing-behaviour I described: If you insert "&nbsp;&nbsp;" only, Firefox will not allow linebreaks there - which is exactly as it should be (after all, nbsp stands for non breaking space). So linebreaks will only be where there happens to be a space in the keywords (i.e. if the search term consists of two words). Solution: Add a normal space in the code after the closing a-Tag.

So, the code from above looks like this and now works all well in Firefox!
Code:
$r = round($rat*$put['count']);
$most_searched .= "<a href=\"search.php?q=". $put['query'] ."\"><font size=\"".$r."\">" . strip_tags($put['query']) . "</font></a> &nbsp;&nbsp;";
Attached you will find the altered addon-code with those changes applied. One version handles clicks like the original (goes to the search-page with the keyword filled in as search-term), one like the version by unitedpunjab (See this post).

---

Furthermore I centered the keywords, which is really easy to do. Instead of the original template-modification-code provided, use this:
Code:
<if condition="$vbulletin->options['setting_searchstats_showuser']">
<tbody>
 <tr>
  <td class="thead" colspan="2">
   <a style="float:$stylevar[right]" href="#top" onclick="return toggle_collapse('forumhome_events')"><img id="collapseimg_forumhome_events" src="$stylevar[imgdir_button]/collapse_thead$vbcollapse[collapseimg_forumhome_events].gif" alt="" border="0" /></a>
$vbphrase[most_searched]
</td>
 </tr>
</tbody>
<tbody id="collapseobj_forumhome_events" style="$vbcollapse[collapseobj_forumhome_events]">
 <tr>
  <td class="alt2"><img src="images/misc/search_stats.gif" alt="$vbphrase[most_searched]" border="0" /></td>
  <td class="alt1" width="100%">$most_searched</td>
 </tr>
</tbody>
</if>
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01214 seconds
  • Memory Usage 1,770KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_code
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete