[Ian Montgomerie]

I tried this and there's a fundamental problem with the coding - it sets up the "unread PMs" folder to be treated the same way as the "sent items" folder. It should be treated like the inbox folder, because the unread PMs are from the inbox. For example, this problem causes all messages in the unread PM list to display as if they were sent by you.

The fix is easy because the "inbox" way of doing things is the default. You just have to remove all of the modifications which look for a "-1" case in the code and change it to "-1 or -2". "-1" is the special case for the sent items folder.

I'm using a shorter, simpler mod file that looks like this. Working with 3.7 PL1.

//################################################################################//
//         MOD NAME: Unread PMs                                                  #//
//################################################################################//
//      DESCRIPTION: Let's users view only unread PMs                            #//
//                   Sorry, folks; this couldn't be done via a plug-in because   #//
//                   it requires changing lines of code which explicitly use     #//
//                   a folder id to identify "system" folders.                   #//
//################################################################################//
//               BY: MPDev                                                       #//
//             DATE: 4.07.07                                                     #//
//          VERSION: 1.0                                                         #//
//################################################################################//
//      FILES UPDATED:                                                           #//
//                   private.php                                                 #//
//                   includes/functions_misc.php                                 #//
//################################################################################//

Please make backups of these two files before editting them so you can back
it out if you want.

//################################################################################//
//                                 private.php                                   #//
//################################################################################//

Find:

	$pmfolders = array('0' => $vbphrase['inbox'], '-1' => $vbphrase['sent_items']);

change to:

	$pmfolders = array('0' => $vbphrase['inbox'], '-1' => $vbphrase['sent_items'], '-2' => 'Unread PMs');

//################################################################################//

Find:

			switch ($vbulletin->GPC['folderid'])
			{
				case -1:

change to:

			switch ($vbulletin->GPC['folderid'])
			{
    			// MDP
				case -2:
					$fromfolder = 'Unread PMs';
					break;
			    // MDP
				case -1:

//################################################################################//


Find:

	($hook = vBulletinHook::fetch_hook('private_messagelist_start')) ? eval($hook) : false;

Add after:

    $foldernames["-2"] = "Unread PMs";
	$show['showunread'] = iif($vbulletin->userinfo['pmunread'], true, false);

//################################################################################//

Find:

		    $pms = $db->query_read_slave("
    			SELECT pm.*, pmtext.*
				    " . iif($vbulletin->options['privallowicons'], ", icon.title AS icontitle, icon.iconpath") . "
			    FROM " . TABLE_PREFIX . "pm AS pm
			    LEFT JOIN " . TABLE_PREFIX . "pmtext AS pmtext ON(pmtext.pmtextid = pm.pmtextid)
			    " . iif($vbulletin->options['privallowicons'], "LEFT JOIN " . TABLE_PREFIX . "icon AS icon ON(icon.iconid = pmtext.iconid)") . "
			    WHERE pm.userid=" . $vbulletin->userinfo['userid'] . " AND pm.folderid=" . $vbulletin->GPC['folderid'] . "
			    ORDER BY pmtext.dateline DESC
			    LIMIT $startat, " . $vbulletin->GPC['perpage'] . "
		    ");


Replace with:

		if ( $vbulletin->GPC['folderid'] == -2 )
		{
		    $pms = $db->query_read_slave("
    			SELECT pm.*, pmtext.*
				    " . iif($vbulletin->options['privallowicons'], ", icon.title AS icontitle, icon.iconpath") . "
			    FROM " . TABLE_PREFIX . "pm AS pm
			    LEFT JOIN " . TABLE_PREFIX . "pmtext AS pmtext ON(pmtext.pmtextid = pm.pmtextid)
			    " . iif($vbulletin->options['privallowicons'], "LEFT JOIN " . TABLE_PREFIX . "icon AS icon ON(icon.iconid = pmtext.iconid)") . "
			    WHERE pm.userid=" . $vbulletin->userinfo['userid'] . " AND pm.folderid=0 AND pm.messageread=0
			    ORDER BY pmtext.dateline DESC
			    LIMIT $startat, " . $vbulletin->GPC['perpage'] . "
		    ");
		}
		else
		{
		    $pms = $db->query_read_slave("
    			SELECT pm.*, pmtext.*
				    " . iif($vbulletin->options['privallowicons'], ", icon.title AS icontitle, icon.iconpath") . "
			    FROM " . TABLE_PREFIX . "pm AS pm
			    LEFT JOIN " . TABLE_PREFIX . "pmtext AS pmtext ON(pmtext.pmtextid = pm.pmtextid)
			    " . iif($vbulletin->options['privallowicons'], "LEFT JOIN " . TABLE_PREFIX . "icon AS icon ON(icon.iconid = pmtext.iconid)") . "
			    WHERE pm.userid=" . $vbulletin->userinfo['userid'] . " AND pm.folderid=" . $vbulletin->GPC['folderid'] . "
			    ORDER BY pmtext.dateline DESC
			    LIMIT $startat, " . $vbulletin->GPC['perpage'] . "
		    ");
		}

//################################################################################//
//                          includes/functions_misc.php                          #//
//################################################################################//

Find:

			$folders = array('0' => $vbphrase['inbox'], '-1' => $vbphrase['sent_items']);

replace with:

            $messagecounters["-2"] = $vbulletin->userinfo['pmunread'];
			$folders = array('0' => $vbphrase['inbox'], '-1' => $vbphrase['sent_items'], '-2' => 'Unread');