[mfyvie]

I've managed to produce a plugin that fixes the uncached templates with this mod, as well as make another plugin that extends the functionality into searches. I've also fixed a small bug. I'll cover each point one by one.

Rather than have these fixes available as a separate file, it would be really great if Computer_Angel could merge these changes into a new version, that way everybody could benefit from the changes.

Uncached templates fixed

If you install the plugin attached to this post you'll find that all templates are now being cached correctly.

Recycle option now appears in searches

There is now an extra plugin that will show the recycle option on the moderator menu when viewing search pages. You are already allowed to select moderation options for threads displayed as search results, so why not have the recycle option here too?

This extra plugin is also included in the same file attached to the bottom of this message.

Bug fix - recycle options no longer appear in recycle bin

I discovered that when viewing threads which are already in the recycle bin the move to recycle option appeared. The same happened when viewing the forum view in the recycle bin. Since it doesn't make any sense to move a thread or threads to the same place the following edits will make sure that you don't get offered this option when in the recycle bin.

In your admincp select Plugins & Products -> Plugin Manager -> *vBRecycle v3* - Forum Display - Edit Template

Find:

$vbulletin->templatecache['FORUMDISPLAY'] = str_replace(
	array(
		'$vbphrase[delete_threads]</option>',
                '$navbar'
	),
	array(
		'$vbphrase[delete_threads]</option> $vbrecycle_fdt',
                '$navbar $vbrecycle_tools'
	),
	$vbulletin->templatecache['FORUMDISPLAY']
);

Replace with:

if ($vbr_ifr['recycle']==1) {
    $vbulletin->templatecache['FORUMDISPLAY'] = str_replace(
	    array(
		    '$vbphrase[delete_threads]</option>',
                    '$navbar'
    	    ),
	    array(
		    '$vbphrase[delete_threads]</option> $vbrecycle_fdt',
                    '$navbar $vbrecycle_tools'
	    ),
	    $vbulletin->templatecache['FORUMDISPLAY']
    );
}

Click save

Then click on *vBRecycle v3* - Show Thread - Edit Template

Find:

$vbulletin->templatecache['SHOWTHREAD'] = str_replace(
    array(
        '$vbphrase[delete_thread]</label></div>'
    ),
    array(
        '$vbphrase[delete_thread]</label></div> $vbrecycle_stt'
    ),
    $vbulletin->templatecache['SHOWTHREAD']
);

Replace with:

if ($vbr_ifr['recycle']!=1) {
    $vbulletin->templatecache['FORUMDISPLAY'] = str_replace(
	    array(
		    '$vbphrase[delete_threads]</option>',
                    '$navbar'
    	    ),
	    array(
		    '$vbphrase[delete_threads]</option> $vbrecycle_fdt',
                    '$navbar $vbrecycle_tools'
	    ),
	    $vbulletin->templatecache['FORUMDISPLAY']
    );
} else {
    $vbulletin->templatecache['FORUMDISPLAY'] = str_replace('$navbar', '$navbar $vbrecycle_tools',$vbulletin->templatecache['FORUMDISPLAY']);
}

Please note: This post applies to version 3.0.9 of vBRecycle. I'm not the author of vBRecycle, but since I didn't have much other choice I've fixed this issue for my own board, and just thought I'd share the fixes.