[aam]

Originally Posted by kitsch

I've sent out a huge batch of e-mails and to my surprise the From: field of the e-mail has been set incorrectly. It should have been:

admin@gsm-forum.eu

and instead it got set to:

"GSM Forum Europe" <GSM Forum Europe@p2pgsm.com>

(p2pgsm.com being the name of the server the forum runs on). So the users received the mail from europe@p2pgsm.com... Which isn't really cool.

Originally Posted by C Braithwaite

Not being funny or anything, but try setting your email address to the correct address in your ACP?
The reason that it is putting that email address is because that is what YOU set it to. any emails sent out from vbulletin will use that email address as the return address/contact address.

I've been playing with your mod (v1.11) and it is very useful, but it needs a bit of tweaking. There is a real problem where the from field is not being generated correctly. I initially thought it must be something to do with the email address in vboptions, but it isn't.

I've noticed that the resultant email "from field" can end up as various things, but generally either "bbtiltle <bbtitle>" or bbtitle<servername>. This can lead to the email being rejected by some mail servers (as the sent email does not have a correct email from header, or a domain indicated and no @).

The problem is due to the way vbmail has been used in remindermail.php. The final email from field is not generated by: (line50)

$uheaders .= "From: " . $vbulletin->options['bbtitle'] . " Reminder Service <" . $vbulletin->options['webmasteremail'] . ">" . "\r\n";

Instead it is from the $from: (line 69)

vbmail($toemail, $subject, $message, $notsubscription = false, $from = $vbulletin->options['bbtitle'], $uheaders = '', $username = '');

So all it was generating was a from based on bbtitle. One way to correctly generate a from field containing the board's email is to change $from to use 'webmasteremail': (line 69)

vbmail($toemail, $subject, $message, $notsubscription = false, $from = $vbulletin->options['webmasteremail'], $uheaders = '', $username = '');

A similar problem can be seen in the reminder report produced (line 79), but this time multiple from email headers are created on the report - one from $from and another from $uheaders.