[TnT]

Hi,

still using Zoints Tags for a few days and found some bugs:

• my Tag cloud gets a mystery last entry 0 (null). But only on my production server (Debian sarge stable). Have done some debugging and found out weird behavior in function array_slice when the second parameter is greater than available tags in db. Fixed it by replacing
  
  PHP Code:

  $tags = array_slice($tags, (($page - 1) * $vbulletin->options['zointstags_showtags']), $vbulletin->options['zointstags_showtags']); 

  with
  
  PHP Code:

      if(count($tags) > $vbulletin->options['zointstags_showtags'])
        $tags = array_slice($tags, (($page - 1) * $vbulletin->options['zointstags_showtags']), $vbulletin->options['zointstags_showtags']); 

• softdeleted threads still shown in threadsearch for all users. My quick fix:
  
  replace
  
  PHP Code:

              $_threads = $db->query_read("
                SELECT * FROM " . TABLE_PREFIX . "thread
                WHERE forumid IN(" . implode(',', $visible) . ")
                AND threadid IN(" . implode(',', $threadids) . ")
                ORDER BY $orderby $direction
                LIMIT $limitlower, $pp
            "); 

  with
  
  PHP Code:

              $_threads = $db->query_read("
                SELECT * FROM " . TABLE_PREFIX . "thread
                WHERE forumid IN(" . implode(',', $visible) . ")
                AND threadid IN(" . implode(',', $threadids) . ")
                AND visible != 2
                ORDER BY $orderby $direction
                LIMIT $limitlower, $pp
            "); 

  not the correct vbulletin way (displaying soft deleted threads with trash can for admins and mods, hide them from guests...), but it works for me.
• build some AJAX Tag suggest for the tag fields. Works like the username suggest in membersearch and shows similar tags. If anyone interested in, I can post the code here.

Thomas