Thread: End-User Options - Mark All Forums Read Confirmation
View Single Post
  #29  
Old 03-19-2007, 02:35 PM
Tralala's Avatar
Tralala Tralala is offline
 
Join Date: Jan 2006
Posts: 1,207
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Dismounted View Post
What is there to debug? The hack is working as designed, it's just that people make modifications to the original usage which creates bugs.
While I agree with what you are saying here, if that's the stance you plan to take, you may want to explicitly state in the first post here that "this mod only provides a confirmation dialog when users click the 'Mark Forums Read' link on Forum Home, and nowhere else."

Because otherwise, one would assume the functionality is extended to every instance of "Mark Forums Read." Why would it not, from a UI standpoint? Why would one "Mark Forums Read" command differ from another?

Clearly there's a desire for consistency with this enhancement. It can be confusing if it works as expected in one place but not another -- especially when it comes to this sort of command where data (read/unread markers) is about to be effectively lost. That's the point of this mod, to give some security and warning back.

And so, as annoying as it may be that folks have begun to "run with" your mod and add stuff and then complain about bugs, I'd look at it as a compliment. Folks really like what you've started here! And so, may I respectfully request that you enhance this a tiny bit to work globally? Pretty please?

Quote:
Originally Posted by Dismounted View Post
You have to change the plugin location to global_complete. I made it at forumhome_complete because it was originally design to be only used for the link on the index.
Quote:
Originally Posted by Smoothie View Post
Has anyone done this and had success? Without thinking I tried global_start instead of global_complete and of course it did not work.
I tried changing it to global_complete and it did not work for me. I'd previously changed the other instances of the "Mark All Forums Read" command to call on the Javascript, but changing the plugin as suggested still didn't bring up the Confirmation dialog.

Still, regardless of what happens with this mod, I want to thank Dismounted for stepping up to the bat and offerring this up. vBulletin has needed this for a long while, and no one else cared to share. So, thanks, Dismounted!
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01274 seconds
  • Memory Usage 1,769KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete