Thread: Miscellaneous Hacks - Advanced Rules and User Agreement Hack v2.0.0
View Single Post
  #29  
Old 03-19-2007, 04:29 AM
whodah whodah is offline
 
Join Date: Feb 2004
Posts: 77
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

First off - thanks for the add-on Mr_Snob!

It appears that Rule #14 gets priority over the group tests (I.e. 1-5).

For instance, I have a rule enabled for "OR from File URL" with the Forum drop down box set to "Destination Forum" and all options beneath it enabled except "URL Exact Match" which is set to "No". (Incidently, I have the URL set to http://www.mydomain.com/showthread.php)

My only "User & Usergroup Options" selections are in the "Primary Usergroup" choices.

Rule #14 then gets a:
Code:
                 $flag      = 1;
                $condflag = 1;
in the template 'parse_templates' no matter if the user is in one of the above selected groups or not.

This would explain some of the issues people were having in version 1.5 of the rules being applied to all usergroups instead of just the ones selected.

I did a kludge to get by... (Basically did another check against the Anonymous usergroup.) But at first glance, a more proper fix may be to combine rule #14 w/ rule 1-5?

Or another approach might be to store $flag as an array of violations rather than a boolean. If one did that, you'd have two benefits:
  1. You could compare the output of Rules 1-5 in subsequent Rule checks (Like pesky Rule #14!)
  2. You could enable a 'debug' option which would spit out exactly which rule was violated. I.e. "Rules violated: 1,5,7" letting admins know a bit more while debugging their rules.
HTH!

-Who Dah?
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03202 seconds
  • Memory Usage 1,766KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete