vb.org Archive - View Single Post - Statistics Modifications - Cyb

Makc666 · #**561** 03-14-2007, 12:11 PM

1.
There is a problem in code here:

Code:

<td class="tcat" colspan="10"><a style="float:$stylevar[right]" href="#top" onclick="return toggle_collapse('cyb_fh_stats')">$cyb_loc_opts<img id="collapseimg_cyb_fh_stats"

10 is not a "good" value.

Of course we have 10 <td> lines below.
But! Only some of them is enabled by default.
4 if I am not mistaken.

And when we have such situation we have BUG in some browsers.

I made a screenshot.

And here is how the generated code looks like:

PHP Code:


			
<td class="tcat" colspan="10"><a style="float:right" href="#top" onclick="return toggle_collapse('cyb_fh_stats')"><img id="collapseimg_cyb_fh_stats"  src="images/buttons/collapse_tcat.gif" alt="" border="0" /></a><a href="http://**************/misc.php?do=cybstats" title="Click here to view more than 10 results">    Top 10 Stats</a></td>

</tr>

</thead>

<tbody id="collapseobj_cyb_fh_stats" style="">

<tr>

<td class="thead" align="left" nowrap="nowrap">Newest Members</td>

<td class="thead" align="left" nowrap="nowrap">Top Posters</td>

<td class="thead" align="left" nowrap="nowrap">Most Viewed Threads</td>

<td class="thead" nowrap="nowrap">Latest Posts</td>

</tr>

You see that there is only 4 (four) <td> lines.

The fix for this bug I see is to count from databse home many colums is enables and replace

Code:

colspan="10"

with some thing like this:

Code:

colspan="$cybtopstats_enabled_colspan"

2.
Also there is some "bad" coding.
I posted a thread here:
https://vborg.vbsupport.ru/showthread.php?t=136982

There is lines in your code like:

Code:

$get_latest_news[titletrimmed] = substr($get_latest_news[title], 0, $trimthreadtitle) . '...';

It is not good to use them. As on forum with UTF-8 databse there will be bugs in displaing trimed words.

You have to replace those lines with this one example:

Code:

$get_latest_news[titletrimmed] = fetch_trimmed_title($get_latest_news[title], $trimthreadtitle);

fetch_trimmed_title - vBulletin's original function which deals/dealts with UTF-8 problem.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01211 seconds Memory Usage 1,794KB Queries Executed 11 (?)
More Information
Template Usage: (1)SHOWTHREAD_SHOWPOST (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (5)bbcode_code (1)bbcode_php (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_box (1)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (1)post_thanks_postbit_info (1)postbit (1)postbit_onlinestatus (1)postbit_wrapper (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit reputationlevel showthread	Included Files: ./showpost.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_postinfo_query fetch_postinfo fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showpost_start bbcode_fetch_tags bbcode_create postbit_factory showpost_post postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start showpost_complete
Messages: