[thincom2000]

Originally Posted by Steve B

line 144 reads

PHP Code:

,    '" . $vbulletin->db->escape_string(implode(", ", $names_a_short)) . "' 


I have tried it with both the database writing and also the file writing with the same error.

Any ideas please?

Originally Posted by sportsoutlaw

I have both of these issues.

I don't have this mod installed, but by the looks of line 144, it could be causing both.

Try changing line 144 to:

PHP Code:

,    '" . $db->escape_string(implode(", ", $names_a_short)) . "' 


If what I say below is true, then this shouldn't change much, except make your code cleaner.

Originally Posted by Steve B

Test site with closed access apart from 4 mods: its showing no names at all, but under Members Visited Statistics: Last 24 Hours: 1 - Last 7 Days: 2 - Last 30 Days: 4 which seems to be right?

This would result in you having only 1 value for $names_a_short which either wouldn't count as an array (but you would get the error 'supplied argument is not an array') OR implode() just wouldn't be happy imploding less than 2 pieces. There is nothing in the php.net documentation about this, though, so it might not be the issue. Just a thought.

In any case, is there a check to do the following?

PHP Code:

if (count($names_a_short) < 2)
{
     // no commas necessary
     $whatever_the_string_is = $db->escape_string($names_a_short);
} 


EDIT: Having downloaded the code, and looking at it, the problem seems to be at line 82:

PHP Code:

        $names_a_short = $names_a_short[0]; 


Looking back at line 81, we see that $names_a_short[0] is in fact from an array, multi-dimensional thanks to array_chunk():

PHP Code:

        $names_a_short = (intval($vbulletin->options['mh_mv_max_forumhome']) == 0 ? array($names_a) : array_chunk($names_a, intval($vbulletin->options['mh_mv_max_forumhome']))); 


The array $names_a_short is formed from whatever $names_a is. The most recent definition of $names_a is line 73, where it is compressed to a single-level array:

PHP Code:

        $names_a["$name[username]"] = $names_a["$name[username]"]['username']; 


Thus, even though my logic makes no sense, this error makes no sense. Line 82 turns record 0 of the multi-level array not into another array, but into a string "Array". And we cannot implode a string...

Comment out line 82 and change line 144 to:

PHP Code:

,    '" . $db->escape_string(implode(", ", $names_a_short[0])) . "' 


OR

Change line 82 to:

PHP Code:

        $names_a_short = array_merge($names_a_short[0]);