Thread: Usenet gateway
View Single Post
  #450  
Old 05-27-2001, 09:58 PM
NgtCrwlr's Avatar
NgtCrwlr NgtCrwlr is offline
 
Join Date: Jan 2002
Location: Fort Myers, FL, USA
Posts: 46
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

While I was validating the output HTML I found that signatures from usenet messages can have invalid characters like (&, and high ASCII chars). htmlentities() action needed?

Also, I would like to see a nl2br in usenet signatures.

Oh-oh I think I hooked a big one!

I knew something wasn't quite right with... function update_last_active_thread because I have one thread title that displays B& amp;W Album. Looking into it further I think I see what is happening.

In function update_last_active_thread you are using
addslashes(htmlspecialchars($lastactivethread))
Unfortunately htmlspecialchars is not needed because vB has already preformed special character conversion and stores it converted in the DB.

This caused me to look further and I found that newnews.pl saves the thread title to the DB without processing for special characters. That would be OK if vB did it that way too.

Paul, tell me I'm wrong... please! If I'm not wrong this means a total purge of all usenet posts and new history pull. This is not that big of a deal for me because I don't have many posting users. Although the news feed I use is terribly slow.

God I love this stuff!

Cheers!
-Larry
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01171 seconds
  • Memory Usage 1,763KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete