Thread: Major Additions - vBonjour - Portal System
View Single Post
  #73  
Old 12-15-2006, 03:10 PM
calorie calorie is offline
 
Join Date: May 2003
Posts: 2,804
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

IMO all the add-ons should be in the same product. They can easily be turned on/off by going to the Plugin Manager. Also the main portal.php file has some issues:
  • define('NO_REGISTER_GLOBALS', 1); // this is no longer used
  • there is no portal_articlelist template
  • if (forumid1) { // this is missing the $ on the variable
  • if (forumid2) { // this is missing the $ on the variable
  • $news['pagetext'] = $parser->do_parse($news['pagetext'], 1, 1, 1, 1); // this is set to parse HTML
  • these should be initialized: $currentsection, $portal_articlebit, $portal_left_column, $portal_right_column
  • $getnews1 and $getnews2 are basically the same query so try WHERE t.forumid IN ($forumid1,$forumid2)
  • vB doesn't store slashes so stripslashes is not needed
  • look into strip_tags, htmlspecialchars_uni, or use title_clean if available instead of the preg_replace regexp
  • is there a need to GLOBAL $parser; for something
  • what setting is this: $vbulletin->options['vbcms_totalrows']
  • $rownum serves no point as the query already has a limit
  • use $navbits[''] = 'Portal'; not with $parent and phrase the word Portal
  • eval('$portal_articlelist .= "' . fetch_template('PORTAL') . '";'); // this serves no purpose
The attached is an untested revision of the portal.php file, though it may need tweaks or fixes as well because it's untested, so it's up to you to test. Hope it helps.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02381 seconds
  • Memory Usage 1,765KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete