[AndrewD]

Originally Posted by elsupremo

Andrew,

I don't know how long this has been going on, but it seems the 2.2.6 series of upgrades have created a problem with Firefox. For one thing, "Save Link As" does not work, and it instead tries to download an html page instead of the download. Secondly, and more significantly, if I left click on the link, the save as dialogue box only has the first 2 characters in my file name - and no extension. Example: I have a file name named: CC 10-07-06 720.wmv. When I left click on it in Firefox, the dialogue box only has "CC" in the save as line, with no extension added.

The left click and save target as functions work normally in both Opera and Internet Explorer (6 and 7).

Thank you for any advice in resolving this issue. I hope you are able to replicate this issue.

Yes, there was a change in the HTTP headers sent before the file, to try to get round another problem. I spotted this in 2.2.6 rc1 but hadn't yet made the new rc available.

Edit local_links.php and go down to line 2094, for the sequence that reads:

	if (HEADER_BEHAVIOUR == "inline") {
//		@header("Content-disposition: inline; filename=\"".$dfname."\"");
		@header("Content-disposition: inline; filename=".$dfname."");
	} else {
		@header("Content-type: application/x-download");
//		@header("Content-disposition: attachment; filename=\"".$dfname."\"");
		@header("Content-disposition: attachment; filename=".$dfname."");
	}

You can do one of two things, depending on your preference. Either swap round the comment flags, so that code reads:

	if (HEADER_BEHAVIOUR == "inline") {
		@header("Content-disposition: inline; filename=\"".$dfname."\"");
//		@header("Content-disposition: inline; filename=".$dfname."");
	} else {
		@header("Content-type: application/x-download");
		@header("Content-disposition: attachment; filename=\"".$dfname."\"");
//		@header("Content-disposition: attachment; filename=".$dfname."");
	}

(which takes it back to 2.2.5 behaviour) or replace the lines by the following:

	if (HEADER_BEHAVIOUR == "inline") {
		@header("Content-disposition: inline; filename=".str_replace(" ", "_", $dfname)."");
	} else {
		@header("Content-type: application/x-download");
		@header("Content-disposition: attachment; filename=".str_replace(" ", "_", $dfname)."");
	}

which is how I intend to handle this in the final 2.2.6 (space in file names will be translated into underscore characters).

Let me know how this works.

As far as the first problem goes, I can't think straight about this - I've just got off the train from a 5 hour journey and need to sleep...