View Single Post
  #1070  
Old 08-05-2006, 05:39 AM
sv1cec sv1cec is offline
 
Join Date: May 2004
Location: Athens, Greece
Posts: 2,091
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Well, if vB is using one of AWS columns, you'd better create new ones. You never know if a user will activate both the AWS and vB's infractions together.

Also, maybe it is a good time to change the names in the program. I have found that some people get frustrated when "warned". Those types who ask you "Are you threatening me?" when you just tell them they did something silly or against the rules. Maybe we should change the "warning" to "ticket" ? I do not know, I can't think of another word.

Also, one more thing.

In the admin_warn.php, there is a small bug. Consider this situation:

- a member has received a warning for 4 points.
- the moderator who warned him made a mistake and issued the wrong warning type.
- since the moderator is not very experienced he "removes" the warning and then issues a new one let's say for 3 points.
- the administrator sees that and decides to completely remove the first warning, since it shouldn't be in the user's record.
- The "Complete Remove" code removes the first warning, but also removes 4 more points from the user, thus the user ends up with zero points. In other words, the Complete Remove code does not separate between deleting an active warning and an inactive one.

A small piece of code in the form of:

Code:
		if ($warn['warned_status']=='A')
		{
			$level=($warn['warning_level']-$warn['warn_points']);
		}
		elseif ($warn['warned_status']=='I')
		{
			$level=($warn['warning_level']);
		}
is needed in the "completeremove" section of admin_warn.php, to separate between removing active and inactive warnings.

Another good idea is to change the wording for remove and complete remove. Maybe the "Remove Warning" should be renamed to "Mature Warning"??

Email me if you want to discuss these further.

Rgds
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01293 seconds
  • Memory Usage 1,766KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete