[Ronin Storm]

This post replaces my previous post on this subject, which I have (or will very shortly) edit to include a pointer direct to this post. Please see the bottom of this post for a bug fix to the original post.

BEGIN PREVIOUS POST:

Not seen this fix mentioned in the past 30 or so pages, nor does it come up on a thread search, so hopefully this is useful to some of you.

The Apostrophe Bug

The problem is that when you type a shout with one or more apostrophes in it when you go to edit that shout only the text up to but not including the first apostrophe appears. This is because, behind the scenes, the shouts are held in blocks delimited by apostrophes... so an apostrophe in the text truncates the result returned.

I've been running this hack-fix for around a week on a live board that receives 1000 or so shouts per week and I've not had any trouble.

In vbshout.php, on approx line 223, find:

PHP Code:

$Shout['s_shout']  = bbcodeparser($Shout['s_shout']); 


... replace with:

PHP Code:

$Shout['s_shout']  = bbcodeparser(str_replace("'", "'", $Shout['s_shout'])); 


On approx line 338, find:

PHP Code:

$vbulletin->GPC['shout'] = convert_urlencoded_unicode($vbulletin->GPC['shout']); 


... replace with:

PHP Code:

$vbulletin->GPC['shout'] = convert_urlencoded_unicode(str_replace("'", "'", $vbulletin->GPC['shout'])); 


On approx line 409, find:

PHP Code:

$Shout['s_shout']  = bbcodeparser($Shout['s_shout']); 


... replace with:

PHP Code:

$Shout['s_shout']  = bbcodeparser(str_replace("'", "'", $Shout['s_shout'])); 


In essence, this replaces instances of apostrophes with the entity reference ' for storage and then converts the entity references back to apostrophes just in time to be displayed.

Please note that I've used the various fixes (and fixes of those fixes) to remove the injection issues highlighted by staffers here. If you're getting " instead of " in your shoutbox then you've probably not applied the fixes described in this thread on the posted "fixed" vbShout code and you probably should not use this hack-fix until you have.

Please let me know if you have any problems with this fix.

(ZT seems to be on indefinite leave so I've bypassed the bug reporting / waiting for response cycle so that people can try this out. I hope I don't offend anyone by this!)

END PREVIOUS POST.

BUG FIX (24 July 2006)

I discovered that there is an issue. Roughly, the issue occurs when you post a shout that has apostrophes, then go to edit it, submit that edit (which also has apostrophes in it) and then edit it again. The second edit retains the original apostrophe bug. This is because the AJAX edit was not also protected in the same way as the original shout.

The changes below should resolve this issue.

In vbshout.php, on approx line 518. find:

PHP Code:

$vbulletin->GPC['shout'] = convert_urlencoded_unicode($vbulletin->GPC['shout']); 


Replace with:

PHP Code:

$vbulletin->GPC['shout'] = convert_urlencoded_unicode(str_replace("'", "'", $vbulletin->GPC['shout'])); 


On approx line 524, find:

PHP Code:

$Shout['s_shout']  = bbcodeparser($Shout['s_shout']); 


Replace with:

PHP Code:

$Shout['s_shout']  = bbcodeparser(str_replace("'", "'", $Shout['s_shout'])); 


And that should be okay now. I believe.

Let me know if you have any issues with it!