[denby]

I have added some code so that another cookie is created/destroyed during login/logout: vb3_username. I have some concerns that perhaps it doesn't behave like the others (domain, expiry etc). I'm not sure that I've covered all the angles so I'd like to check with you all. These are the mods:

/includes/functions_login.php
in function verify_authentication:
AFTER
vbsetcookie('password', md5($vbulletin->userinfo['password'] . COOKIE_SALT));
INSERT
vbsetcookie('username', $vbulletin->userinfo['username']);

AFTER
vbsetcookie('password', '');
INSERT
vbsetcookie('username', '');

in function process_new_login:
AFTER
vbsetcookie('password', md5($vbulletin->userinfo['password'] . COOKIE_SALT), 0);
INSERT
vbsetcookie('username', $vbulletin->userinfo['username'], 0);
[twice: once for the ACP or upgrade script login, and once for the Mods CP]

/includes/init.php
AFTER
COOKIE_PREFIX . 'languageid' => TYPE_UINT,
INSERT
COOKIE_PREFIX . 'username' => TYPE_STR,


Can anyone think of anything I've missed?