vb.org Archive - More upgrade instruction problems..

I don't know what the problem is, but a lot of the instructions in the latest upgrade seem to be telling me to locate code that's a little bit different than before.

An examples:

From the installation instructions for 3.4.4, the version I installed two days ago:

PHP Code:


		
			
In the same file, find:



        // ### NOT PREVIEW - ACTUAL POST ###

        if ($newpost['visible'])

        {



Right below that, add the following:



            // Change for automatic warning

            // You have to use "ObsceneWords" as Title of the Warning.

            // You have to use a Hidden Warner.

            if ($vboptions['warn_automatic'] == 1)

            {

                $Protected_Usergroups = explode("|",$vboptions['warn_protected_usergroups']);

                if($Protected_Usergroups[0])

                {

                    foreach($Protected_Usergroups as $pro)

                    {

                        if($pro == $bbuserinfo['usergroupid'])

                        {

                            $userprotected = 1;

                        }

                    }

                }

                if ($bbuserinfo['userid'] != 1 AND $userprotected != 1 AND $wehavecensoredwords == 1)

                {

                    // Get Warning Types

                    $warn_type = array();

                    $warn_type = $DB_site->query_first("SELECT * FROM " . TABLE_PREFIX . "warning_types WHERE warn_name='ObsceneWords'");

                    $thread1="[URL='{$vboptions['bburl']}/showthread.php?p={$_POST['postid']}']Warned Post[/URL]";

                    $thread2="$vboptions[bburl]/showthread.php?p=$newpostid";

                    $warnerdata=$DB_site->query_first("select username, email from ".TABLE_PREFIX."user where userid='{$vboptions['warn_automatic_warner']}'");

                    if ($alert=='')

                    {

                        $alert='No';

                    }

                    warn_calculations($warn_type['tid'], $wcomment, $newpostid, $bbuserinfo, $vboptions['warn_automatic_warner'], $alert);

            

                    warn_notify($thread1, $thread2, $bbuserinfo, $warnerdata['email'], $warnerdata['username'], $vboptions['warn_automatic_warner'], $warn_type, $level, $wcomment, $alert);

                }

            }

            // End of automated warnings things

In the latest download, the upgrade instructions from 3.4.4 to 3.4.5 state this:

PHP Code:


		
			
3. Edit newreply.php and find:



            $wcomment="(This is an automatic warning, no moderator was involved.)";

            if ($alert=='')

            {

                $alert='No';

            }

            warn_calculations($warn_type['tid'], $wcomment, $newpostid, $bbuserinfo, $vboptions['warn_automatic_warner'], $alert);

            

            warn_notify($thread1, $thread2, $bbuserinfo, $warnerdata['email'], $warnerdata['username'], $vboptions['warn_automatic_warner'], $warn_type, $level, $wcomment,$alert);



Replace this with:



            $wcomment=$original_text;

            if ($alert=='')

            {

                $alert='No';

            }

            warn_calculations($warn_type['tid'], $wcomment, $newpostid, $bbuserinfo, $vboptions['warn_automatic_warner'], $alert);

            

            $wcomment="(This is an automatic warning, no moderator was involved.)";

            

            warn_notify($thread1, $thread2, $bbuserinfo, $warnerdata['email'], $warnerdata['username'], $vboptions['warn_automatic_warner'], $warn_type, $level, $wcomment,$alert);

Now, is it me, or was the following line never even in the 3.4.4 installation instructions?

PHP Code:


		
			
            $wcomment="(This is an automatic warning, no moderator was involved.)";

It's in the newest installation instructions, but not in the one I had. This makes it very confusing when upgrading. Please advise...

Also, for English users, in the pm_newpm, that line should read: You appear to be the Collector of this site. Under which ID do you want this message to be sent?

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01060 seconds Memory Usage 1,758KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (3)bbcode_php_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (3)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: