vb.org Archive - no match found query

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)

- - no match found query (https://vborg.vbsupport.ru/showthread.php?t=77405)

vbted

03-03-2005 07:02 PM

no match found query

OK, this works for me but if no match is found in the four fields I get an error. I would like $formpmid to equal "1" if no match is found. any help would be great. I'm ob a sql noob. -Ted

Any other comments on the code would be great also.

PHP Code:


		
			
////////////////////////////////////////////////

if ($normalanswer1 == ''){

    $formpmid = "1"; }

else {

$result = $DB_site->query("SELECT userid

                           FROM " . TABLE_PREFIX . "userfield

                           WHERE (field19 = '$normalanswer1') OR (field26 = '$normalanswer1') OR (field15 = '$normalanswer1') OR (field25 = '$normalanswer1')");

while ($usersid = $DB_site->fetch_array($result)) 

    {  

    $formpmid = $usersid['userid'];

    }

}

//////////////////////////////////////////////////

Marco van Herwaarden

03-04-2005 05:36 AM

PHP Code:


		
			
$formpmid = 1;  

if ($normalanswer1 != ''){ 

$result = $DB_site->query("SELECT userid 

                           FROM " . TABLE_PREFIX . "userfield 

                           WHERE (field19 = '$normalanswer1') OR (field26 = '$normalanswer1') OR (field15 = '$normalanswer1') OR (field25 = '$normalanswer1')"); 

while ($usersid = $DB_site->fetch_array($result)) 

    {   

    $formpmid = $usersid['userid']; 

    } 

}

Something like this i guess. But you don't say what error you are getting.

vbted

03-04-2005 06:53 PM

Thanks! works perfect. I geuass when no match was found in the db the code didn't know how to handle it. much tanx. -Ted

filburt1

03-04-2005 06:54 PM

You should be aware that you have a dangerous SQL injection problem. You need to wrap all of the variables in the query with addslashes().

http://www.php.net/addslashes

vbted

03-04-2005 07:08 PM

Like this??

PHP Code:


		
			
$formpmid = 1;   

if ($normalanswer1 != ''){ 

$result = $DB_site->query("SELECT userid 

                           FROM " . TABLE_PREFIX . "userfield 

                           WHERE (field19 = '" . addslashes($normalanswer1) . "') 

          OR (field26 = '" . addslashes($normalanswer1) . "') 

          OR (field15 = '" . addslashes($normalanswer1) . "') 

          OR (field25 = '" . addslashes($normalanswer1) . "')"); 

while ($usersid = $DB_site->fetch_array($result)) 

    {    

    $formpmid = $usersid['userid']; 

    } 

}

filburt1

03-04-2005 09:17 PM

Yes, that's correct. :)

BTW, the parenthesis in the query aren't necessary, although they don't hurt either.

vbted

03-04-2005 09:31 PM

thanks for the input.

All times are GMT. The time now is 12:27 PM.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01300 seconds Memory Usage 1,737KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (3)bbcode_php_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (7)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: