vb.org Archive - Join question I think??

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)

- - Join question I think?? (https://vborg.vbsupport.ru/showthread.php?t=61670)

Jalrock

02-17-2004 08:39 PM

Join question I think??

the two tables are "reputation" & "user".

I get the info from "reputation" but want to translate the userid in to a username via the user table.

the script looks like this...

PHP Code:


		
			
$sql = "(SELECT * FROM reputation ORDER BY $order)"; 

$result = mysql_query($sql);   



while($myrow = mysql_fetch_array($result)) {  

    $postid = $myrow["postid"];      

    $userid = $myrow["userid"];   

    $reputation = $myrow["reputation"];   

    $whoadded = $myrow["whoadded"];   

    $reason = $myrow["reason"];

    $dateline = $myrow["dateline"];

  

    

      

echo "<tr><td><a href=\"http://www.twins.combinedwealth.com/forum/showthread.php?p=$postid\">$postid</a></td><td><a href=\"http://www.twins.combinedwealth.com/forum/member.php?u=$userid\">$username</a><td>$reputation</td>\n<td><a href=\"http://www.twins.combinedwealth.com/forum/member.php?u=$whoadded\">$whoadded</a></td>\n<td width=\"350\">$reason .</td><td>$dateline</td>\n</tr>";

}

any help appreciated.

Dean C

02-17-2004 08:50 PM

This is not a nice way of doing it - firstly if this is for vB make use of the built in class.

mysql_query(); = $DB_site->query();
mysql_fetch_array(); = $DB_site->fetch_array();

And so on...

Secondly use templates as it's a lot cleaner method

Thirdly for your join :)

PHP Code:


		
			
SELECT reputation.*,user.* FROM reputation LEFT JOIN user ON user.userid=reputation.userid ORDER BY $order

-------

You may want to try and limit it too as if you have 100+ users as soon as they all have their reputations you're going to be pulling 100+ users at a time.

Andreas

02-17-2004 08:53 PM

Try

PHP Code:


		
			
$sql = "SELECT reputation.*,user.username FROM " . TABLE_PREFIX . "reputation AS reputation LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid=reputation.userid) ORDER BY $order";

All times are GMT. The time now is 02:39 AM.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01161 seconds Memory Usage 1,723KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (3)bbcode_php_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (3)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: