vb.org Archive - Is this hack safe?

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB3 General Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=111)

- - Is this hack safe? (https://vborg.vbsupport.ru/showthread.php?t=49624)

Randomlove

03-04-2003 11:30 AM

Is this hack safe?

Hi,
I'm new to this so take it easy everyone :)

Most of my users come from behind a proxy. In order to record the right IP when they register I did the following with register.php (vB 2.2.5, I won't upgrade until 2.3.0 becomes stable :)).

Line 450 is the one that actually inserts a new user into the DB. It says:

Code:

  $DB_site->query("INSERT INTO user (userid,username,password,email,".$newstylefield."parentemail,coppauser,homepage,icq,ai$

I did this BEFORE that line:

Code:

  $ipaddress=iif(getenv("REMOTE_ADDR")!="",getenv("REMOTE_ADDR"),$HTTP_HOST);

  $ipaddress=iif(getenv("HTTP_X_FORWARDED_FOR")!="",getenv("HTTP_X_FORWARDED_FOR"),$ipaddress);

First line will record the regular IP, the second checks if there is a fowarded IP. REMOTE_ADDR might hold the proxy IP not the real IP.

My question is, will this affect $ipaddress somewhere else? Are the two lines safe and will cause a security problem?

Thanks.
Take care,

R.L. :)

Randomlove

03-04-2003 05:55 PM

Hmmm, is my question that difficult? Or is it very stupid? :)

Issvar

03-04-2003 06:04 PM

Someone could just add the x_forwarded header to the output of his browser, and so fake his ip. You should also record the real ip.

Also someone using multiple chained proxies that set x_forwarded wouldn't have his/her real IP recorded.

Randomlove

03-04-2003 06:13 PM

Well, most of my users are IT-challenged :), so I don't think they can do such tricks. Secondly, I can't do what you suggested because I don't get in trouble once I decide to upgrade to 2.3.0

Thanks for the comment, but you didn't say whether there is any bad side-effect for the the two lines up there.

Take care,
R.L. :)

All times are GMT. The time now is 11:00 PM.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.00901 seconds Memory Usage 1,711KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (4)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: