vb.org Archive - db error

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)

- - db error (https://vborg.vbsupport.ru/showthread.php?t=48069)

Boofo

01-24-2003 04:31 AM

db error

I just got the following error while trying to send a private message. Can someone please tell me what is happening here and maybe how to fix it?

Quote:

Database error in vBulletin 2.2.9:

Invalid SQL: INSERT INTO privatemessage (privatemessageid,userid,touserid,fromuserid,title ,message,dateline,showsignature,iconid,messageread ,folderid,receipt,attachmentid,showimage) VALUES (NULL,28,28,1,'try again','If you get a chance, can you please try what you did before again? Also, did you get a \"page not found\" or \"this page can not be displayed\" error?',1043389319,'1','0',0,0,1,0,)
mysql error: You have an error in your SQL syntax near ')' at line 1

mysql error number: 1064

Date: Friday 24th of January 2003 06:21:59 AM
Script: http://www.bearfacts2.com/forum/forum/private.php
Referer: http://www.bearfacts2.com/forum/private.php

Xenon

01-24-2003 11:29 AM

look at the end: "0,1,0,)"

you hav a , where it shouldn't be :)

Boofo

01-24-2003 11:54 AM

No matter who tries to send a pm, they get a db error now. Here's the code in question:

Code:

$DB_site->query("INSERT INTO privatemessage (privatemessageid,userid,touserid,fromuserid,title,message,dateline,showsignature,iconid,messageread,folderid,receipt,attachmentid,showimage) VALUES (NULL,$touserinfo[userid],$touserinfo[userid],$bbuserinfo[userid],'".addslashes(htmlspecialchars($title))."','".addslashes($message)."',".time().",'$signature','$iconid',0,0,$receipt,$attachmentid,$showimage)");

Xenon

01-24-2003 03:55 PM

seems the showimage makes problems..

change it to:

PHP Code:


		
			
$DB_site->query("INSERT INTO privatemessage (privatemessageid,userid,touserid,fromuserid,title,message,dateline,showsignature,iconid,messageread,folderid,receipt,attachmentid,showimage) VALUES (NULL,$touserinfo[userid],$touserinfo[userid],$bbuserinfo[userid],'".addslashes(htmlspecialchars($title))."','".addslashes($message)."',".time().",'$signature','$iconid',0,0,$receipt,$attachmentid,".intval($showimage).")");

Boofo

01-24-2003 04:55 PM

I did this and it now seems to work. But is this the right way to do it or should I change it to what you have in the post abaove?

PHP Code:


		
			
 $DB_site->query("INSERT INTO privatemessage (privatemessageid,userid,touserid,fromuserid,title,message,dateline,showsignature,showimage,iconid,messageread,folderid,receipt,attachmentid) VALUES (NULL,$touserinfo[userid],$touserinfo[userid],$bbuserinfo[userid],'".addslashes(htmlspecialchars($title))."','".addslashes($message)."',".time().",'$signature','$showimage','$iconid',0,0,$receipt,$attachmentid)");

I also moved it in the lines, but I don't think it really matters where it is at in there, does it?

Xenon

01-24-2003 09:35 PM

no it doesn't matter where in the string it is...

well, your and my query are different.
yours hasn't the hack in anymore, mine would work with the hack (whichone it ever was?)

so if you don't need the hack yours is correct, if it's a needed hack you should use mine

Boofo

01-24-2003 10:57 PM

The hack is still in there. I moved it behind showsignature and '$signature'. All I did was change $showimage to '$showimage' and it started working. What I was asking is am I going to have problems somewhere else with that change? What does ".intval($showimage)." do that '$showimage' doesn't do, or vice-versa?

Xenon

01-25-2003 11:11 AM

well it depends on how you save the value in the db.

lets say $showimage is an empty string, then '$showimage' would become '', intval($showimage) would become that: 0

so if you save in the db as integer, you should use intval

All times are GMT. The time now is 08:16 PM.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.02267 seconds Memory Usage 1,735KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)bbcode_code_printable (2)bbcode_php_printable (1)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (8)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: