vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB3 General Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=111)
-   -   Is the unindexpost() function unnecessarily complicated, or am I missing something? (https://vborg.vbsupport.ru/showthread.php?t=46620)

sparky2 12-13-2002 03:00 AM

Is the unindexpost() function unnecessarily complicated, or am I missing something?
 
an observation based on v2.2.9 code:

Although 3 arguments are passed to the function
(the post id, the post title, and post.pagetext)
only ONE ~~ postid ~~ is needed.

Further:
the preg_replace stuff, the "SELECT wordid, title blahblah" query
along with the AND-ed DELETE query, are unnecessary!

This function could (SHOULD) be simplified to the point of
just accepting the postid as an argument, and querying
DELETE from searchindex where postid='$postid'

Considering that each of the calling scripts have the postid available
in the first place, the function (and calls to it) could be removed entirely
by placing the SQL (delete) query right in the scripts (postings.php,
and editpost.php)

Freddie Bingham 12-13-2002 05:16 AM

<a href="http://www.vbulletin.com/forum/showthread.php?postid=384909#post384909" target="_blank">http://www.vbulletin.com/forum/showt...909#post384909</a>


All times are GMT. The time now is 12:09 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.00937 seconds
  • Memory Usage 1,704KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (2)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete