vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)
-   -   Number format (https://vborg.vbsupport.ru/showthread.php?t=42975)

Boofo 08-31-2002 03:47 AM
Number format
 
Can anyone please tell me an easier way to do this? I want to have the thread views in a number format (with an apostrophe after 1000). Here is the code I got it to work with but there must be a better and easier way to accomplish this.

PHP Code:
$dbview = $DB_site->query_first("SELECT SUM(views) AS totalviews FROM thread");
$allviews = $dbview[totalviews];
$countviews=$DB_site->query_first("SELECT SUM(views) AS views FROM thread WHERE postuserid='$userinfo[userid]'");
$userthreadviews=$countviews['views'];
$threadviewpercent = round(($userthreadviews / $allviews) * 100,2);
$userthreadviews=number_format($countviews['views']);
if ($userthreadviews AND $threadviewpercent <> "0") {
    eval("\$threadviews = \"".gettemplate("getinfo_threadviews")."\";");
  } else {
        $threadviews = '';
  } 
This is the line I had to insert to get it to work right.

PHP Code:
$userthreadviews=number_format($countviews['views']); 
I tried doing the number_format in the first instance of this code, but it messed up the percentage of totalviews there.

futureal 08-31-2002 05:39 AM
The problem is that number_format(...) changes the resulting variable to a string. If you look back at that code, the variable you are converting ($userthreadviews) is used in an if(...) statement in the next line.

Try the following code:

PHP Code:
$dbview = $DB_site->query_first("SELECT SUM(views) AS totalviews FROM thread");
$allviews = $dbview[totalviews];
$countviews=$DB_site->query_first("SELECT SUM(views) AS views FROM thread WHERE postuserid='$userinfo[userid]'");
$userthreadviews=$countviews['views'];
$threadviewpercent = round(($userthreadviews / $allviews) * 100,2);
$userthreadviews=$countviews['views'];
if ($userthreadviews AND $threadviewpercent <> "0") {
    $userthreadviews = number_format($userthreadviews);
    eval("\$threadviews = \"".gettemplate("getinfo_threadviews")."\";");
  } else {
        $threadviews = '';
  } 
The basic idea is, only use number_format(...) right before you display the value, to ensure that you're not screwing up any future logic (there could be more in this case, I wouldn't know without looking at the whole code...)

Boofo 08-31-2002 06:20 AM
Thanks for clearing that up for me. :) The code I had above worked, but I had to put two lines in it to make it work. I didn't realize I could move it down to just before I evaluated the template. Thanks again. This will definitely help in the future as well. :)


All times are GMT. The time now is 02:42 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01170 seconds
  • Memory Usage 1,728KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_php_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (3)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete