vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)
-   -   Is there a way to tell in a while loop if you're on the last iteration? (https://vborg.vbsupport.ru/showthread.php?t=42087)

JJR512 08-09-2002 04:12 AM
Is there a way to tell in a while loop if you're on the last iteration?
 
I have some code that generates a "|"-separated list of forums that users are able to see. If a user has access to the forum, it appears in the list; if he/she doesn't, it doesn't. But the way I have it now, the | character appears after every forum name. I'd like it to not appear after the last forum name. I think I need to have some way of telling if a while loop is on the last go-round, if you know what I mean...if it's the last time the loop is going to execute.

Here's what I have:
PHP Code:
// Begin Forumlinks
$forumlinksperms=$DB_site->query("SELECT forumid,title,parentid FROM forum WHERE active='1' ORDER BY displayorder");
$forumlink = "";
while ($forumlinksperm=$DB_site->fetch_array($forumlinksperms)) {
  $getperms=getpermissions($forumlinksperm[forumid]);
  if ($getperms[canview]) {
    if ($forumlinksperm[parentid]=='-1') {
      $forumlink .= "<b>$forumlinksperm[title]</b> | ";
    } else {
      $forumlink .= "$forumlinksperm[title] | ";
    }
  }
}
// End Forumlinks 
So, if I had, say, five forums, named Forum1, Forum2,...Forum5, and assuming all were accessible, you would see this:
Quote:
Forum1 | Forum2 | Forum3 | Forum4 | Forum5 |
I'd like to make it so you see this:
Quote:
Forum1 | Forum2 | Forum3 | Forum4 | Forum5
How can I do this?

Neo 08-09-2002 04:41 AM
Well you could always count how many forums there are using COUNT() and then add something like this $i++

Example:

PHP Code:
// Begin Forumlinks

$countforum=$DB_site->query("SELECT COUNT(*) AS total FROM forum WHERE active='1'");
$forumcount = $countforum['total'];

$forumlinksperms=$DB_site->query("SELECT forumid,title,parentid FROM forum WHERE active='1' ORDER BY displayorder");
$forumlink = "";
$i=0;
while ($forumlinksperm=$DB_site->fetch_array($forumlinksperms)) {
$i++;
  $getperms=getpermissions($forumlinksperm[forumid]);
  if ($getperms[canview]) {
    if ($forumlinksperm[parentid]=='-1') {
      $forumlink .= "<b>$forumlinksperm[title]</b> | ";
    } elseif ($forumcount == $i) {
      $forumlink .= "$forumlinksperm[title]";
    } else {
      $forumlink .= "$forumlinksperm[title] | ";
    }
  }
}
// End Forumlinks 

It adds a extra query.. but this might work.

Sparkz 08-09-2002 07:10 AM
Or you can simply remove the last three chars of the string since they will always be " | "...

Neo 08-09-2002 07:26 AM
whatever works best I really have no clue since me != sleep ><

Admin 08-09-2002 07:28 AM
Err, very bad way Neo. If anything you should just use $DB_site->num_rows() to get the number of records.

But like sparkz said, use substr() once you're done:
PHP Code:
// Begin Forumlinks
$forumlinksperms=$DB_site->query("SELECT forumid,title,parentid FROM forum WHERE active='1' ORDER BY displayorder");
$forumlink = "";
while ($forumlinksperm=$DB_site->fetch_array($forumlinksperms)) {
  $getperms=getpermissions($forumlinksperm[forumid]);
  if ($getperms[canview]) {
    if ($forumlinksperm[parentid]=='-1') {
      $forumlink .= "<b>$forumlinksperm[title]</b> | ";
    } else {
      $forumlink .= "$forumlinksperm[title] | ";
    }
  }
}
$forumlink = substr($forumlink, 0, -3);
// End Forumlinks 

JJR512 08-09-2002 09:15 PM
FireFly, thank you so very much! I've used the substr method. Just chopping off the end was by far the simplest solution. :)

I was pretty sure ahead of time no method of counting the number of results in a query (like with $DB_site->num_rows()) woud work, because the number of results in the last query was further reduced by the if ($getperms[canview]) part. In other words, not all of the results from the query would end up being used, so in all likelihood, the highest number would never be reached.


All times are GMT. The time now is 08:58 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01421 seconds
  • Memory Usage 1,747KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_php_printable
  • (2)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (6)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete