vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Member Archives (https://vborg.vbsupport.ru/forumdisplay.php?f=202)
-   -   Hack Efficiency (https://vborg.vbsupport.ru/showthread.php?t=3728)

10-06-2000 05:09 AM


10-06-2000 08:33 AM

Cool...Thanks for the info...I just went through all my addons and started optimizing...lets hope it helps.

10-06-2000 08:45 AM

How does this code look to you. Any suggestions would be appreciated:
Code:

<?
require("/home/php/pbcity/vb/admin/config.php");
$num_active = 8;
$num_chars = 95;

$db=mysql_connect($servername,$dbusername,$dbpassword);
mysql_select_db($dbname);

$querylatest="select forumid, title, dateline, threadid, postusername, replycount, lastposter from thread where forumid='1' or forumid='2' or forumid='3' or forumid='4' or forumid='5' or forumid='7' or forumid='8' or forumid='9' or forumid='10' or forumid='11' or forumid='12' or forumid='13' or forumid='14' or forumid='15' or forumid='16' or forumid='17' or forumid='18' or forumid='19' or forumid='20' or forumid='22' or forumid='23' or forumid='26' or forumid='27' or forumid='28' or forumid='32' or forumid='34' or forumid='35' or forumid='36' or forumid='37' or forumid='38' or forumid='39' or forumid='40' or forumid='41' or forumid='42' order by lastpost desc limit $num_active";
$resultlatest = mysql_query($querylatest,$db);

print("<center><table width=\"100%%\" cellspacing=\"0\" cellpadding=\"2\">");

while ($latest_array = mysql_fetch_array($resultlatest)) {

// Get Forum Infomation
$query_forum = "select * from forum where forumid='$latest_array[forumid]' limit 1";
$result_forum = mysql_query($query_forum,$db);
$forum_info_array = mysql_fetch_array($result_forum);

printf("<tr><td colspan=\"2\" bgcolor=\"#87A4C2\"><b><font color=\"#000000\" size=\"1\" face=\"Verdana, Arial, Helvetica, sans-serif\">%s: %s</font></b></td></tr>",$forum_info_array["title"],$latest_array["title"]);

// split the date up a bit
$datestr1 = substr($latest_array["dateline"],0,10);
$datetime = substr($latest_array["dateline"],11,8);
printf ("<tr valign=\"top\"><td width=\"15%%\" bgcolor=\"#B9B9B9\"><font face=\"Verdana, Arial, Helvetica, sans-serif\" size=\"1\"><b>%s</b><br>Updated: %s<br>Replies: %s</font></td>", $latest_array["postusername"], $datetime, $latest_array["replycount"]);

$querythread="select * from post where threadid='$latest_array[threadid]' order by dateline asc limit 1";

$result_thread_text= mysql_query($querythread,$db);

$result_thread_array = mysql_fetch_array($result_thread_text);
printf ("<td width=\"85%%\" bgcolor=\"#cccccc\"><font face=\"Verdana, Arial, Helvetica, sans-serif\" size=\"1\"><img src=\"http://forums.paintballcity.com/images/icons/icon%s.gif\"> Last Post By: %s<hr>%s...<br><a href=\"http://forums.paintballcity.com/showthread.php?threadid=%s\">Click here for more</font></td></tr>",$result_thread_array["iconid"],$latest_array["lastposter"],substr(strip_tags($result_thread_array["pagetext"]),0,$num_chars),$latest_array["threadid"]);
printf ("<tr><td colspan=\"2\" width=\"100%%\"> </td></tr>");
}

printf ("</table></center>");
?>

[Edited by VirtueTech on 10-06-2000 at 05:48 AM]

10-07-2000 12:40 PM

Code:

where forumid!='0'
Nonono - that's bad. Use:

WHERE forumid<>'0'

10-07-2000 01:10 PM

Couldn't you change:

select * from forum where forumid='$latest_array[forumid]' limit 1

to:

select title from forum.....

and change

select * from post where threadid='$latest_array[threadid]' order by dateline asc limit 1

to

select iconid, pagetext from post where.....

???

10-07-2000 04:32 PM

Quote:

Originally posted by MrBlunt
Why would != as a comparision be bad? According to the MySQL Docs it is the same as <>. Unless I missed something. (I just re-read them) I just find it easier to read and understand. I have used that on lots of PHP and Perl programs connecting to MySQL, Oracle and SQL Server and never had a problem. What are the pitfalls?
I've seen certain versions of MySQL that like to die when it comes to != - but I haven't seen anything die on <>

10-07-2000 06:36 PM

Well != is not very portable in SQL where <> is so there no good reason to even get in the habit of using !=

!= should be left to C and PHP (and any other programming language that happens to use it)

And BTW JAMES you really need to edit the newreply template and set the cell that the reply box is in to 100% so it doesn't run way off the screen as it does on this reply. Also aligning the Buttons to the left side would help.


All times are GMT. The time now is 11:47 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01130 seconds
  • Memory Usage 1,730KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (1)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (7)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete