vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)
-   -   I need some help with this if/else statement (https://vborg.vbsupport.ru/showthread.php?t=36399)

Parker Clack 03-21-2002 10:15 PM
I need some help with this if/else statement
 
I have added the option in the User Control Panel to select whether or not you want an email response each time some one replies to a thread you have requested email notifications on or just the one time (as is vBulletin's default).

I have added a row to the User table called allemail and then
in the email notification section of the functions.php file I added

if ($bbuserinfo['allemail']==0) {
$useremails=$DB_site->query("SELECT user.*
FROM subscribethread,user
WHERE subscribethread.threadid='$threadid'
AND subscribethread.userid=user.userid
AND user.userid<>'$userid'
AND user.lastactivity>'$lastposttime[dateline]'");
} else {

$useremails=$DB_site->query("SELECT user.*
FROM subscribethread,user
WHERE subscribethread.threadid='$threadid'
AND subscribethread.userid=user.userid
AND user.userid<>'$userid'");
}

When they select "No" the value is zero and they should just get one response. If "Yes" they should get a response each time. As
it is working now though they get a response each time. So it appears to me that the if statement isn't working and it just defaults to the last statement. Allemail is getting set to 1 or 0 just fine from the user control panel but the script does not appear to recognize the if else routine.

Any ideas on how to get this to work?

Thanks,
Parker

Mark Hensler 03-22-2002 04:35 AM
simple debuging skills... "When in doubt, print it out." ;)

print the value of $bbuserinfo['allemail']

Parker Clack 03-22-2002 08:11 AM
Mark:

Sorry, I am not the great of a coder. How would I go about printing this out?

Parker

Admin 03-22-2002 10:24 AM
Is $bbuserinfo available in that function?

Parker Clack 03-22-2002 12:18 PM
Chen:

It should be. Here is a bit more of the code in question as I have it written into the existing code.

Code:
....$lastposttime=$DB_site->query_first("SELECT dateline
                                      FROM post
                                      WHERE threadid='$threadid'
                                      ORDER BY dateline DESC
                                      LIMIT ".iif($moderated, '1,1', '1'));
  // if it's moderated, the post has already been inserted, so we want the one before that

  if ($bbuserinfo['allemail']==0) {
  $useremails=$DB_site->query("SELECT user.*
                              FROM subscribethread,user
                              WHERE subscribethread.threadid='$threadid'
                                AND subscribethread.userid=user.userid
                                AND user.userid<>'$userid'
                                AND user.lastactivity>'$lastposttime[dateline]'");
  } else {

  $useremails=$DB_site->query("SELECT user.*
                              FROM subscribethread,user
                              WHERE subscribethread.threadid='$threadid'
                                AND subscribethread.userid=user.userid
                                AND user.userid<>'$userid'");
  }

  $threadinfo[title]=unhtmlspecialchars($threadinfo['title']);

  $temp = $bbuserinfo['username'];
  if ($postid) {
    $postinfo = getpostinfo($postid);
    $bbuserinfo['username'] = unhtmlspecialchars($postinfo['username']);
    $bbuserinfo['email'] = unhtmlspecialchars($postinfo['email']);
    $postemail = $bbuserinfo['email'];
  } else {
    if (!$bbuserinfo['userid']) {
      $bbuserinfo['username'] = unhtmlspecialchars($postusername);
      $bbuserinfo['email'] = unhtmlspecialchars($postuseremail);
      $postemail = $bbuserinfo['email'];
    } else {
      $bbuserinfo['username'] = unhtmlspecialchars($bbuserinfo['username']);
      $bbuserinfo['email'] = unhtmlspecialchars($bbuserinfo['email']);
      $postemail = $bbuserinfo['email'];
    }
  }
  while ($touser=$DB_site->fetch_array($useremails)) {
    $touser['username']=unhtmlspecialchars($touser['username']);

............................................
Since bbuserinfo userid, email, username are available and allemail in in the same user table I would think that it would be called up with no problem too.

Any ideas?

Parker

Admin 03-22-2002 12:33 PM
Oh ok I see the problem now, you are coding this the wrong way.

Replace this:
Code:
  $useremails=$DB_site->query("SELECT user.*
                              FROM subscribethread,user
                              WHERE subscribethread.threadid='$threadid'
                                AND subscribethread.userid=user.userid
                                AND user.userid<>'$userid'
                                AND user.lastactivity>'$lastposttime[dateline]'");
Code:
  $useremails=$DB_site->query("SELECT user.*
                              FROM subscribethread,user
                              WHERE subscribethread.threadid='$threadid'
                                AND subscribethread.userid=user.userid
                                AND user.userid<>'$userid'");
And add this:
Code:
    if (!$touser['allemail'] and $touser['lastactivity']<=$lastposttime['dateline'])
      continue;
Right after this:
Code:
  while ($touser=$DB_site->fetch_array($useremails)) {

Parker Clack 03-22-2002 12:50 PM
Ok so I would end up with

Code:
$lastposttime=$DB_site->query_first("SELECT dateline
                                      FROM post
                                      WHERE threadid='$threadid'
                                      ORDER BY dateline DESC
                                      LIMIT ".iif($moderated, '1,1', '1'));
  // if it's moderated, the post has already been inserted, so we want the one before that

  $useremails=$DB_site->query("SELECT user.*
                              FROM subscribethread,user
                              WHERE subscribethread.threadid='$threadid'
                                AND subscribethread.userid=user.userid
                                AND user.userid<>'$userid'");
 

  $threadinfo[title]=unhtmlspecialchars($threadinfo['title']);

  $temp = $bbuserinfo['username'];
  if ($postid) {
    $postinfo = getpostinfo($postid);
    $bbuserinfo['username'] = unhtmlspecialchars($postinfo['username']);
    $bbuserinfo['email'] = unhtmlspecialchars($postinfo['email']);
    $postemail = $bbuserinfo['email'];
  } else {
    if (!$bbuserinfo['userid']) {
      $bbuserinfo['username'] = unhtmlspecialchars($postusername);
      $bbuserinfo['email'] = unhtmlspecialchars($postuseremail);
      $postemail = $bbuserinfo['email'];
    } else {
      $bbuserinfo['username'] = unhtmlspecialchars($bbuserinfo['username']);
      $bbuserinfo['email'] = unhtmlspecialchars($bbuserinfo['email']);
      $postemail = $bbuserinfo['email'];
    }
  }
  while ($touser=$DB_site->fetch_array($useremails)) {
  if (!$touser['allemail'] and $touser['lastactivity']<=$lastposttime['dateline'])
      continue;
Correct?

Thanks,
Parker

Admin 03-22-2002 01:03 PM
Yes.

Parker Clack 03-22-2002 01:13 PM
Chen:

Again that did it and again you have helped me out a great deal.

Thanks,
Parker


All times are GMT. The time now is 01:18 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01141 seconds
  • Memory Usage 1,745KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (6)bbcode_code_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (9)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete