vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB4 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=252)
-   -   $var = $var unexpected result (https://vborg.vbsupport.ru/showthread.php?t=324761)

Thr33 03-18-2017 12:39 PM
$var = $var unexpected result
 
I run a vBulletin plugin that has always worked fine until recently i upgraded Apache and PHP from 5.4 to 5.5 and suddonly a calculation isnt working the way it should do:

PHP Code:
$RUser = $row2['reputation'];
$RUserMinus = $RUser-1; 
Instead of $RuserMinus being the result of $Ruser -1 it's replacing the value with -1 so $RUserMinus = "-1" instead of the result.

FULL SCRIPT

PHP Code:
$query2 = $db->query_read("SELECT reputation FROM user WHERE userid =" . $vbulletin->userinfo['userid']) or die(mysql_error()); 

while($row2 = mysql_fetch_array( $query2 )) { 
$RUser = $row2['reputation']; 
} 
$RUserMinus = $RUser-1; 

$vbulletin->db->query_write("UPDATE user SET reputation=".$RUserMinus." WHERE userid=".$vbulletin->userinfo['userid']) or die (mysql_error()); 
} 

Dave 03-18-2017 12:59 PM
Try
PHP Code:
$RUserMinus = ($RUser - 1); 

Thr33 03-18-2017 01:37 PM
Same result, changes the value to -1

Quote:
Originally Posted by Dave (Post 2584024)
Try
PHP Code:
$RUserMinus = ($RUser - 1); 

MarkFL 03-18-2017 02:25 PM
Try putting the statement:

PHP Code:
$RUserMinus = $RUser-1; 
within the while loop. :)

Thr33 03-18-2017 02:37 PM
Database Error
]]> Database error in vBulletin 4.2.3
Invalid SQL: UPDATE user SET reputation= WHERE userid=2;
MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE userid=2' at line 1
Error Number : 1064
Request Date : Saturday, March 18th 2017 @ 03:37:01 PM
Error Date : Saturday, March 18th 2017 @ 03:37:01 PM
Script : http://literecords.com/sandbox/post_thanks.php
Referrer : http://literecords.com/sandbox/showt...php?2-rep-test
Classname : vB_Database_MySQLi
MySQL Version : 5.5.54-cll
]]>

MarkFL 03-18-2017 02:46 PM
Rather than use a db query to get the browsing user's reputation, I would simply use:

PHP Code:
$vbulletin->userinfo['reputation'] 
Thus, your code becomes:

PHP Code:
$RUserMinus = $vbulletin->userinfo['reputation'] - 1; 

$vbulletin->db->query_write("UPDATE user SET reputation=" . $RUserMinus . " WHERE userid=".$vbulletin->userinfo['userid']) or die (mysql_error()); 

Thr33 03-18-2017 02:51 PM
Im not sure if that work as i use 2 queries in the full plugin script is:

PHP Code:
if ($vbulletin->userinfo['userid'] !== $threadinfo['postuserid'])   
{   

$query = $db->query_read("SELECT reputation FROM user WHERE userid =" . $threadinfo['postuserid']) or die(mysql_error()); 

while($row = mysql_fetch_array( $query )) {    
$OPRep = $row['reputation'];   
$OPRepPlus = $OPRep+1;  } 

$vbulletin->db->query_write("UPDATE user SET reputation=".$OPRepPlus." WHERE userid=".$threadinfo['postuserid']) or die (mysql_error()); 

$query2 = $db->query_read("SELECT reputation FROM user WHERE userid =" . $vbulletin->userinfo['userid']) or die(mysql_error());   

while($row2 = mysql_fetch_array( $query2 )) {     
$RUser = $row2['reputation'];   
$RUserMinus = $RUser-1;  } 

$vbulletin->db->query_write("UPDATE user SET reputation=".$RUserMinus." WHERE userid=".$vbulletin->userinfo['userid']) or die (mysql_error());   
 
}   
else   
{    
} 
--------------- Added [DATE]1489852566[/DATE] at [TIME]1489852566[/TIME] ---------------

AHHHH it f*cking works!! You absolute legend! Do you make music? I'll give you a privileged account haha!

--------------- Added [DATE]1489852778[/DATE] at [TIME]1489852778[/TIME] ---------------

When i did it for the -1 part it worked great but when i adapted to the +1 part it give me the same database error as earlier ^^

PHP Code:
if ($vbulletin->userinfo['userid'] !== $threadinfo['postuserid'])    
{    
$OPRepPlus = $vbulletin->userinfo['reputation'] + 1;  

$vbulletin->db->query_write("UPDATE user SET reputation=".$OPRepPlus." WHERE userid=".$threadinfo['postuserid']) or die (mysql_error()); 
   
$RUserMinus = $vbulletin->userinfo['reputation'] - 1;  

$vbulletin->db->query_write("UPDATE user SET reputation=".$RUserMinus." WHERE userid=".$vbulletin->userinfo['userid']) or die (mysql_error());    
} 
else    
{     
} 
--------------- Added [DATE]1489853144[/DATE] at [TIME]1489853144[/TIME] ---------------

PHP Code:
$vbulletin->userinfo['reputation'] 
I think i see the problem. This line grabs the replying member's reputation. I need to find the thread starter's reputation.

--------------- Added [DATE]1489853318[/DATE] at [TIME]1489853318[/TIME] ---------------

It's deducting -1 from thread starter's reputation instead of +1


All times are GMT. The time now is 01:06 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01676 seconds
  • Memory Usage 1,764KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (10)bbcode_php_printable
  • (1)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (7)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete