![]() |
Social Media Plugin Code Review
1 Attachment(s)
Hello friends, I've been learning PHP and creating my first plugin the past few days. I'm using Nexia's OpenGraph Protocol Inserts as a basis for my project, so many thanks and credits for this great modification. I've shot him an email asking permission to perhaps update/release this project and am waiting to hear back.
The plugin accomplishes this so far:
This is what is adds to the HTML: Code:
<meta property="og:description" content="Long tutorial here, gonna upload it in 4 seperate parts! It is 1.5 hours long and will explain everything you need to know to get started using IDA Pro! https://vborg.vbsupport.ru/external/2016/05/11.png Instead of: https://vborg.vbsupport.ru/external/2016/05/12.png Combining this with some simple social share buttons makes my social marketing campaign 2easy I was hoping to get some feedback on my code from the pros. Currently on vb4.2.3 and vbAdvanced 4.3.0 Please don't install if you don't know what you're doing, I've tested it thoroughly but am not an expert |
The code looks fine. The only comment I can make about it is that you should avoid using $GLOBALS. It's bad practice to use that these days.
|
I agree with Dave on both counts. I've never needed to use $GLOBALS.
But, congratulations on creating your first product. But be warned...it can be addictive. :) |
Could you fine fellas enlighten on me on how I would access $GLOBALS['threadinfo']['description']
without using $GLOBALS? Thanks in advance |
Quote:
$threadinfo['description'] |
Quote:
|
All times are GMT. The time now is 02:48 PM. |
Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information | |
---|---|
|
|
![]() |
|
Template Usage:
Phrase Groups Available:
|
Included Files:
Hooks Called:
|