vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)
-   -   [SOLVED] security token problem with a form in my plugin (https://vborg.vbsupport.ru/showthread.php?t=318030)

omardealo 03-29-2015 03:57 PM
[SOLVED] security token problem with a form in my plugin
 
Hello ,

i used this code in my plugin in hook : misc_start
this is a form to do insert on database

PHP Code:

// this VAR $order on while loop and i print it on a template 
$order = '<td class="alt2">
<form action="misc.php?do=points_usergift&giftid='.$resultgift[giftid].'&pointgift='.$resultgift[giftpoints].'" method="post">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="securitytoken" value="$bbuserinfo[securitytoken]" />
<input type="hidden" name="do" value="points_usergift" />
<input type="submit" class="button" value="submit" />
</form></td>';


if ($_REQUEST['do'] == 'points_usergift')
{ 
if($vbulletin->userinfo['user_points'] > $_POST["pointgift"]) 
{ 
eval(standard_error(fetch_error('points_nopermission'))); 
}else{ 
$db->query_write("INSERT INTO " . TABLE_PREFIX . " points_usergift  
(giftid,userid,dateline)  
VALUES   
('".$_POST['giftid']."','".$vbulletin->userinfo['userid']."','".TIMENOW."') 
"); 
eval(print_standard_redirect('points_addredirect',1,1));
} 
} 

i think something is missing about session , and i think if i put a form in a template will be working good but i want but it on a plugin
This error appears

Your submission could not be processed because a security token was invalid.

If this occurred unexpectedly, please inform the administrator and describe the action you performed before you received this error.

kh99 03-29-2015 04:35 PM
I think you need to change the string so that the variables are evaluated, like this:
PHP Code:
$order = '<td class="alt2">
<form action="misc.php?do=points_usergift&giftid='.$resultgift[giftid].'&pointgift='.$resultgift[giftpoints].'" method="post">
<input type="hidden" name="s" value="'.$session[sessionhash].'" />
<input type="hidden" name="securitytoken" value="'.$bbuserinfo[securitytoken].'" />
<input type="hidden" name="do" value="points_usergift" />
<input type="submit" class="button" value="submit" />
</form></td>'; 
(the changes are around $session[sessionhash] and $bbuserinfo[securitytoken]).

Also, is that the entire plugin code? If so, you should really check $_REQUEST['do'], otherwise you will interfere with other functions in misc.php (but maybe you only posted part of the plugin).

omardealo 03-29-2015 05:08 PM
Quote:
Originally Posted by kh99 (Post 2541849)
I think you need to change the string so that the variables are evaluated, like this:
PHP Code:
$order = '<td class="alt2">
<form action="misc.php?do=points_usergift&giftid='.$resultgift[giftid].'&pointgift='.$resultgift[giftpoints].'" method="post">
<input type="hidden" name="s" value="'.$session[sessionhash].'" />
<input type="hidden" name="securitytoken" value="'.$bbuserinfo[securitytoken].'" />
<input type="hidden" name="do" value="points_usergift" />
<input type="submit" class="button" value="submit" />
</form></td>'; 
(the changes are around $session[sessionhash] and $bbuserinfo[securitytoken]).

Also, is that the entire plugin code? If so, you should really check $_REQUEST['do'], otherwise you will interfere with other functions in misc.php (but maybe you only posted part of the plugin).
thanks brother , Do you think is very logical, but unfortunately it did not work.
Do you have other suggestions?
And Do not worry about $_REQUEST['do'] code, I'm quite sure that there's no problem with any another php code . Only problem in form code .:up:

this the outpot :
PHP Code:
<input type="hidden" name="securitytoken" value=""> 
if it read the value will be working good

-----------------

okay now i think it working good ,
PHP Code:
<input type="hidden" name="securitytoken" value="'.$vbulletin->userinfo[securitytoken].'" /> 
output :
PHP Code:
<input type="hidden" name="securitytoken" value="1427652798-6a37957adfc30da0463f00be052e3848a2225666"> 
thanks brother , You provide good help here

kh99 03-29-2015 06:33 PM
Oh, right, I should have remembered that $session and $bbuserinfo only work in templates.

omardealo 04-04-2015 01:47 PM
Quote:
Originally Posted by kh99 (Post 2541854)
Oh, right, I should have remembered that $session and $bbuserinfo only work in templates.
Yeah Me too, thank you my dear brother :up:


All times are GMT. The time now is 04:05 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01172 seconds
  • Memory Usage 1,746KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (6)bbcode_php_printable
  • (2)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (5)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete