vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB4 General Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=251)
-   -   How to fix that all inline images are showed only as full? (https://vborg.vbsupport.ru/showthread.php?t=309136)

RedFoxy 03-03-2014 09:05 PM

How to fix that all inline images are showed only as full?
 
Hello!
I've a strange trouble, all the inline images are shown at full size, untile the file is just inserted inline I can change image/thumbnail setting double clicking it, but after I post the message the images are shoe at full size.
I tried to use a CLEAN template and disable ALL mods but nothing... I've vBulletin 4.2.2 and I've that trouble on two different boards.

My template vars about thumbnail are:
Inline Attached Image Thumbnail Maximum Size: 150px
Inline Attached Image Medium Maximum Size: 300px
Inline Attached Image Large Maximum Size: 1024px

Any suggest to fix it?

Lynne 03-03-2014 09:28 PM

I assume the two forums are on the same server? Have you tried setting up a test site on that server - totally new install - and seeing if you have the same problem right out of the box?

RedFoxy 03-03-2014 11:18 PM

No I haven't tried, but on vbulletin.com there are other people with same trouble.
I does a video of the trouble: http://www.redfoxy.it/vbulletin_inline.mp4
As you can see, the inline image was translated in [IMG] tag

Barcham 03-04-2014 02:53 PM

Just out of curiosity, have you verified your image settings in the admincp under Message Attachment Options? There are a few settings there that can affect how images are displayed in posts on the board.

RedFoxy 03-04-2014 04:35 PM

Quote:

Originally Posted by Barcham (Post 2485028)
Just out of curiosity, have you verified your image settings in the admincp under Message Attachment Options? There are a few settings there that can affect how images are displayed in posts on the board.

Yes I do, it's all ok

I've an update for that trouble, looks like thats a trouble of the wysiwyg editor, when I insert inline a thumbnail with the wysiwyg disabled, it insert a [ATTACH ] tag but if I switch from textual editor to wysiwyg and than I switch again to text it change the attach tag to img tag!

--------------- Added [DATE]1393954791[/DATE] at [TIME]1393954791[/TIME] ---------------

Just to be sure, my Message Attachment Options are:
  • Limit Space Taken Up By Attachments (Total): 0
  • Attachments Per Post: 0
  • Attachment Upload Inputs: 10
  • Attachment URL Inputs: 10
  • Allow Deletion of Attachments Beyond Edit Time Limit: no
  • Allow Deletion of Attachments in Closed Threads: No
  • Allow Duplicate Attached Images: No
  • Resize Images: Yes
  • View Attached Images Inline: Yes, display thumbnails
  • CMS Thumbnail Override: Yes
  • Thumbnail Creation: Yes
  • Thumbnail Size: 100
  • Thumbnail Quality: 65
  • Thumbnails Per Row: 5
  • Thumbnail Color: #000000
  • Use Image Lightbox: Yes, click
  • Asset Manager - Enable: Yes, ajax upload by default
  • Asset Manager - Assets per Page: 20
  • Advanced Insert Image Popup - Enable: Yes

--------------- Added [DATE]1393992215[/DATE] at [TIME]1393992215[/TIME] ---------------

Ok, now there is something of weird...

Test 1: I tried to install a clean vBulletin 4.2.2 on my official server, using a new DB, after I installed it I tried to verify the inline trouble and that clean vBulletin have that trouble.

Test 2: I've a fresh installed local Virtual Machine with FreeBSD, like the official server, with about all package installed, I tried to installa a fresh vBulletin 4.2.2 but that installation have inline image trouble too...

Test 3: Fresh install of lastes stable Debian with Apache 2 (not Nginx as official server), than I've installed a fresh vBulletin 4.2.2 and... It goes! There isn't inline trouble!

After a fast debug I found similar errors on test 1 and 2:
Code:

Warning: preg_match() [function.preg-match]: Compilation failed: invalid range in character class at offset 23 in ..../includes/class_wysiwygparser.php on line 481
Than I tried to understand it and editing includes/class_wysiwygparser.php at 481 I find:
Code:

                if (preg_match('#attachment.php\?attachmentid=(\d+)#si', $img_url, $matches) AND preg_match('#class=(\'|"|)([a-z0-9_-\s]+)?\s*previewthumb\s*([a-z0-9_-\s]+)?(\\1)#si', $fullurl))
                {
                        return '[ATTACH=CONFIG]' . $matches[1] . '[/ATTACH]';
                }

To test it I got the 2 variables ($img_url and $fullurl) and I make a file test.php
<?php
$img_url ='http://192.168.1.55/attachment.php?attachmentid=36&amp;stc=1';
$fullurl ='<img src="http://192.168.1.55/attachment.php?attachmentid=36&amp;stc=1" attachmentid="36" alt="" id="vbattach_36" class="previewthumb">';

if (preg_match('#attachment.php\?attachmentid=(\d+)#s i', $img_url, $matches) AND preg_match('#class=(\'|"|)([a-z0-9_-\s]+)?\s*previewthumb\s*([a-z0-9_-\s]+)?(\\1)#si', $fullurl))
{
echo "it's ok";
}
?>

If I run that file on freebsd server it give error:
Warning: preg_match(): Compilation failed: invalid range in character class at offset 23 in x.php on line 5

But if I run it on the Debian server it goes!
That's really strange, some suggest to fix it?

RedFoxy 03-05-2014 07:14 PM

Ok I got it! PCRE 8.34 have a bug, it's all ok with PCRE 8.33

Barcham 03-05-2014 07:59 PM

Glad to see you got it worked out! :up:

Lynne 03-06-2014 02:11 AM

Quote:

Originally Posted by RedFoxy (Post 2485264)
Ok I got it! PCRE 8.34 have a bug, it's all ok with PCRE 8.33

Wow! That's quite interesting. Thank you so much for letting us know what was going on!

tbworld 03-06-2014 02:30 AM

Quote:

Originally Posted by RedFoxy (Post 2485264)
Ok I got it! PCRE 8.34 have a bug, it's all ok with PCRE 8.33

Thanks for letting us know! :)

I am looking into the changelog for PCRE 8.34 against the expression to see what has changed. If it is not a bug, I will post a new updated expression. Great work!

RedFoxy 03-20-2014 09:24 PM

Ok I fixed it, in the regex you must change _- with -_

Change:
Quote:

if (preg_match('#attachment.php\?attachmentid=(\d+)#s i', $img_url, $matches) AND preg_match('#class=(\'|"|)([a-z0-9_-\s]+)?\s*previewthumb\s*([a-z0-9_-\s]+)?(\\1)#si', $fullurl))
With:
Quote:

if (preg_match('#attachment.php\?attachmentid=(\d+)#s i', $img_url, $matches) AND preg_match('#class=(\'|"|)([-_a-z0-9\s]+)?\s*previewthumb\s*([-_a-z0-9\s]+)?(\\1)#si', $fullurl))


All times are GMT. The time now is 11:00 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01131 seconds
  • Memory Usage 1,748KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (5)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete