vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)
-   -   strip_bbcode optimization...makes forums run faster (https://vborg.vbsupport.ru/showthread.php?t=287842)

ttkaminski 09-14-2012 06:32 PM
strip_bbcode optimization...makes forums run faster
 
I had some performance problems with the strip_bbcode() function in includes/functions.php. I investigated and found that for certain types of content (with lots of bbcodes), the code runs slow and gives bad results.

I made some small tweaks to the regex that improved results. Here is a patch

Code:
--- a/includes/functions.php        2012-09-14 11:11:52.000000000 -0400
+++ b/includes/functions.php    2012-09-14 15:17:39.000000000 -0400
@@ -2313,7 +2313,7 @@

        if ($stripimg)
        {
-              $find[] = '#\[(attach|img|video).*\].+\[\/\\1\]#siU';
+                $find[] = '#\[(attach|img|video)[^\]]*\].+\[\/\\1\]#siU';
                $replace[] = '';
        }

@@ -2322,7 +2322,7 @@
        {

                // any old thing in square brackets
-              $find[] = '#\[.*/?\]#siU';
+              $find[] = '#\[[^\]]*\]#si';
                $replace[] = '';

                $message = preg_replace($find, $replace, $message);
Please review, and if it's good, then hopefully vbulletin devs will include this patch in the next release.


All times are GMT. The time now is 10:26 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01348 seconds
  • Memory Usage 1,708KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (1)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete