random banner code - what am I doing wrong?
 

I found some code on another forum that's supposed to show a random banner within vbulletin. People posting in the thread got it to work, but I'm stuggling. If someone wouldn't mind taking a look and telling me what I'm doing wrong, I'd greatly appreciate it.

I created a new plugin, with the hook location of "global_start" with this code:

I've tried placing $bannerrotator in the bottom of the navbar template and also in the ad location in the ads section, but neither work. Instead I get "$bannerrotator" where the ad should appear. What am I doing wrong?

Thanks guys.

The problem is that that was intended for vb3. But it should work in vb4 with a few changes. First, use hook parse_templates. Next, add the following line to the end of the plugin code (for the navbar template):

Then in the navbar template, use {vb:raw bannerrotator}.

Thank you very much for the help. Got it working. :D

I am having the same trouble. Total noob question...

When you say the navbar template, where do I find this to insert the {vb:raw bannerrotator}. ?

Admincp > Styles & Templates > Style Manager > find style > Edit Templates

Thanks!

Okay, I have yet to get this to work properly. I posted this code:

$banner[1] = "<a href="http://bham-jk.com/showthread.php?1015-Meet-N-Mod-Party" target="_blank"><img src="http://i93.photobucket.com/albums/l72/JOHNNYP4409/MeetNModparty_zps9e808cc0.jpg" border="0" alt="MeetnModParty"/></a>";
$banner[2] = "<a href="http://www.tntaccessoriesnservicecenter.com/" target="_blank"><img src="http://i93.photobucket.com/albums/l72/JOHNNYP4409/TNTBannerBlack.png" border="0" alt="TNTaccessories"></a>>";

$rotator = rand(1, 2);

$bannerrotator = $banner[$rotator];

vB_Template:: preRegister('navbar', array('bannerrotator' => $bannerrotator));

Then put this in the "ad_global_below_navbar" template:

{vb:raw bannerrotator}

Then I get this error:
Parse error: syntax error, unexpected T_STRING in /home/bhamjk/public_html/includes/class_bootstrap.php(430) : eval()'d code on line 1

So, what have I done wrong?

The problem is that you've put double quotes around strings that contained double quotes, so they're mismatched. If you use single quotes instead it should work, like:


Also I noticed that the $banner[2] string has >> at the end, I don't know if that's a typo or not.

dam just posted about the double >> but was beat to it

Thanks guys. I got those fixed. Not showing any errors now, but the banner still doesn't show up.

Using VB4 if that helps