vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB4 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=252)
-   -   How do I Add {option} to built-in [code] (https://vborg.vbsupport.ru/showthread.php?t=283515)

dushokd 05-26-2012 11:15 PM
How do I Add {option} to built-in [code]
 
I have been modifying the "bbcode_code" template. How do I add an option to the built-in code tag?

Built in:
[ CODE ] some random code [ /CODE ]

With Option:
[ CODE=javascript ]some random code[ /CODE ]

Then I could print out the option to display the type of code, instead of just the word "Code" it would say "JavaScript Code". below is an example of the bbcode_code template and {option} should just print out the option.
Code:
<div class="bbcode_container">
        <div class="bbcode_description">{option} {vb:rawphrase code}:</div>
        <pre class="bbcode_code"<vb:if condition="$vboptions['codemaxlines']">style="height:<vb:if condition="$blockheight<$vboptions['codemaxlines']">{vb:math {vb:raw blockheight}*{vb:stylevar mid_fontSize}+{vb:stylevar mid_fontSize}*2}<vb:else />{vb:math {vb:raw blockheight}*{vb:stylevar mid_fontSize}+{vb:stylevar mid_fontSize}}</vb:if>;"</vb:if>>{vb:raw code}</pre>
</div>
Thanks,
Dave

kh99 05-26-2012 11:45 PM
I don't think you can do that without editing the file includes/class_bbcode.php.

Assuming you're willing to do that: If you search that file for [code] you find it in two places. In one place it's adding to the tag array. There you could add a second entry ($tag_list['option']['code']) that has the same values as the 'no_option' tag.

The other place you'll find [code] is at the function handle_bbcode_code. There you need to add a second parameter for the option, then register that to the template. You'll also probably want to add a check in the template for the option value being null (which will happen with a code tga with no option).

dushokd 05-27-2012 03:26 AM
Thanks kh99, I am almost there, but there is some bug I can't figure out, I hope you can help?

using [ code ] without the option works perfectly. When I pass the option, it displays correctly, but if I try and edit the post, i see that the [ code ] tags have been removed and reformatted.

Result when trying to edit post when I included the option:
http://koshok.com/vb/code_01.png

Below is my code.
function:
PHP Code:
function handle_bbcode_code($code, $option = '')
    {
        global $vbulletin, $vbphrase, $show;

        // remove unnecessary line breaks and escaped quotes
        $code = str_replace(array('<br>', '<br />'), array('', ''), $code);

        $code = $this->strip_front_back_whitespace($code, 1);

        if ($this->printable)
        {
            $code = $this->emulate_pre_tag($code);
            $template = 'bbcode_code_printable';
        }
        else
        {
            $blockheight = $this->fetch_block_height($code);
            $template = 'bbcode_code';
        }
        
        if ($option == '1') {
            $option = 'happy';
        } else {
            $option = 'sad';
        }
            
        $templater = vB_Template::create($template, true);
            $templater->register('option', $option);
            $templater->register('blockheight', $blockheight);
            $templater->register('code', $code);
        return $templater->render();
    } 
tag_list:
PHP Code:
//[CODE]
            $tag_list['no_option']['code'] = array(
                'callback'          => 'handle_bbcode_code',
                'strip_empty'       => true,
                'disable_smilies'   => true,
                'disable_wordwrap'  => true,
                'strip_space_after' => 2
            );
            
            //[CODE=XXX]
            $tag_list['option']['code'] = array(
                'callback'          => 'handle_bbcode_code',
                'strip_empty'       => true,
                'disable_smilies'   => true,
                'disable_wordwrap'  => true,
                'strip_space_after' => 2
            ); 
bbcode_code:
Code:
<div class="bbcode_container">
        <div class="bbcode_description">{vb:raw option}:</div>
        <pre class="bbcode_code"<vb:if condition="$vboptions['codemaxlines']">style="height:<vb:if condition="$blockheight<$vboptions['codemaxlines']">{vb:math {vb:raw blockheight}*{vb:stylevar mid_fontSize}+{vb:stylevar mid_fontSize}*2}<vb:else />{vb:math {vb:raw blockheight}*{vb:stylevar mid_fontSize}+{vb:stylevar mid_fontSize}}</vb:if>;"</vb:if>>{vb:raw code}</pre>
</div>

DivisionByZero 05-27-2012 03:49 AM
why can't the dev team just put all the built-in code in the BB Code Manager in the first place? I've been meaning to ask this question for years!

kh99 05-27-2012 04:07 AM
Quote:
Originally Posted by dushokd (Post 2333365)
Thanks kh99, I am almost there, but there is some bug I can't figure out, I hope you can help?

Yeah, sorry - obviously I didn't actually try it. Anyway, more changes needed in includes/class_bbcode_alt.php. Around line 99, after the "make the "pre" tags use the correct handler" for loop (ETA ...add this under the existing foreach loop):

Code:
                if (isset($this->tag_list['option']['code']))
                {
                        $this->tag_list['option']['code']['callback'] = 'handle_preformatted_tag';
                        unset($this->tag_list['option']['code']['html'], $this->tag_list['option']['code']['strip_space_after']);
                }

then in handle_preformatted_tag() around line 357, replace the return statement with:

Code:
                return '[' . $tag_name .
                        ($this->current_tag['option'] !== false ?
                                ('=' . $this->current_tag['delimiter'] . $this->current_tag['option'] . $this->current_tag['delimiter']) :
                                ''
                        ) . ']' . $this->emulate_pre_tag($code) . "[/$tag_name]";

(which I stole from another function).

There's also another class in that file, vB_BbCodeParser_PlainText, which probably needs to be changed for when the post is represented as plain text.


Quote:
Originally Posted by DivisionByZero (Post 2333369)
why can't the dev team just put all the built-in code in the BB Code Manager in the first place? I've been meaning to ask this question for years!
I don't know, but the handling of some of those codes is a lot more complicated than just a replacement, so it would be difficult.

DivisionByZero 05-27-2012 04:11 AM
That's true, indeed. However, there could be an include file (with hooks) for each bbcode that can be easily edited and make it easier for upgrades.

kh99 05-27-2012 04:18 AM
That would be nice.

DivisionByZero 05-27-2012 04:20 AM
if we suggest it now, maybe it'll get implemented in a few years.

kh99 05-27-2012 04:49 AM
heh heh...yeah, it's probably not on the top of the list. I was just thinking about it - I think the main problem is that the way it's written now, the callback functions for handling bbcodes have to be member functions of the bbcode parser class. But it would be easy enough to allow other callback functions, and then I think a lot more could be done in a plugin.

DivisionByZero 05-27-2012 04:51 AM
i cant even find a way to do it in my admincp project (https://vborg.vbsupport.ru/showthread.php?t=282849) without frontend code modification. I've been thinking about it long and hard too.


All times are GMT. The time now is 06:33 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01239 seconds
  • Memory Usage 1,761KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_code_printable
  • (2)bbcode_php_printable
  • (2)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete