vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB4 General Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=251)
-   -   Advance edit strips br tags in 4.1.9 (https://vborg.vbsupport.ru/showthread.php?t=276153)

paulket 12-29-2011 03:36 AM

Advance edit strips br tags in 4.1.9
 
Whenever the advance edit option is used, all of the br tags in a post are being stripped (the separation between paragraphs is lost). I'm using vBulletin 4.1.9 and I have tried disabling all of my plugins but the problem still persists.

Any help in getting this fixed would really be appreciated.

Lynne 12-30-2011 05:08 PM

This is a known bug - search WYSIWYG in Jira. There is a .diff file in the report if you are able to use those.

paulket 12-30-2011 09:06 PM

Lynne, in Jira I found http://tracker.vbulletin.com/browse/VBIV-13639 and downloaded the .diff file. How would I know what should be changed in the clientscript/vbulletin_quick_edit.js file? There are no instructions to do this on Jira.

Lynne 12-30-2011 11:36 PM

You would use the .diff file to make the changes or read the diff file via a text editor and make the changes manually (- means remove the line + means add the line). You may do a search to find instructions on how to do this (on a PC) over on vbulletin.com

paulket 12-31-2011 04:40 PM

OMG, why can't they just make the corrected files available to overwrite the bad files?!?! I read what is needed to use the .diff file and while I'm not an absolute newbie to adding mods and making template edits, etc., this is way over my head and a ridiculous way of fixing a problem.

I hope it is fixed in 4.1.10 and that a stable version of 4.1.10 will be released soon.

Lynne 12-31-2011 04:46 PM

They've been providing .diff files as a way to fix a bug reported file for years now.

How to use Patch files (*.diff) for patching your vBulletin installation

HMBeaty 12-31-2011 04:54 PM

Quote:

Originally Posted by paulket (Post 2282557)
I hope it is fixed in 4.1.10

Since it's marked as "Approved on Staging" for 4.1.10, it should be fixed ;)

paulket 12-31-2011 04:55 PM

Quote:

Originally Posted by Lynne (Post 2282559)
They've been providing .diff files as a way to fix a bug reported file for years now.

How to use Patch files (*.diff) for patching your vBulletin installation

Lynne, I found that explanation and it is ridiculous for vBulletin to expect their customers to do all of that to fix their broken product.

To do it manually the .diff file say to change the following in clientscript/vbulletin_quick_edit.js

Code:

-                form.add_variable('message', vB_Editor[vB_QuickEditor.editorid].get_editor_contents());
to
Code:

+                form.add_variable('message', vB_Editor[vB_QuickEditor.editorid].getRawData());
Minus the - and + of course.

form.add_variable('message', vB_Editor[vB_QuickEditor.editorid].get_editor_contents()); Doesn't even exist in clientscript/vbulletin_quick_edit.js :confused:

kh99 12-31-2011 05:02 PM

I think they probably mean this:

Code:

A.add_variable("message",vB_Editor[vB_QuickEditor.editorid].get_editor_contents());

I guess the variable names get changed to one letter in the distribution to cut down the file size. (but I don't know why the diff would have 'form').

HMBeaty 12-31-2011 05:07 PM

In the same file (/clientscript/vbulletin_quick_edit.js), try changing this:
PHP Code:

A.add_variable("message",vB_Editor[vB_QuickEditor.editorid].get_editor_contents()); 

To this:
PHP Code:

A.add_variable("message",vB_Editor[vB_QuickEditor.editorid].getRawData()); 

*This has not been tested*

EDIT: Kevin posted as I was going through the file lol


All times are GMT. The time now is 04:47 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02219 seconds
  • Memory Usage 1,739KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_code_printable
  • (2)bbcode_php_printable
  • (2)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete