vb.org Archive - Need some help fixing code

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB4 General Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=251)

- - Need some help fixing code (https://vborg.vbsupport.ru/showthread.php?t=272857)

Need some help fixing code

In the Showthread template we had a coder ad some vertical ad code. See them at www.huskermax.com/vbbs.

After the ad code was put in the quick reply button stopped working.

Below is showthread as is with quick reply not working. I bolded the ad code that if I take it out everything works with out the ads but put it back in and quick reply does not work but has the ads. Do I need to put the bolded code somewhere else? I can see it is right in the middle of the quick reply code.

See next post.

--------------- Added [DATE]1319647981[/DATE] at [TIME]1319647981[/TIME] ---------------

Code:

{vb:stylevar htmldoctype}

<html xmlns="http://www.w3.org/1999/xhtml"<vb:if condition="$vboptions['enablefacebookconnect']"> xmlns:fb="http://www.facebook.com/2008/fbml"</vb:if> dir="{vb:stylevar textdirection}" lang="{vb:stylevar languagecode}" id="vbulletin_html">

<head>

        <SCRIPT>

var a = Math.floor(Math.random()*9999999999+1)

var random_number = a;

</SCRIPT>

        {vb:raw headinclude}

        <vb:if condition="$threadinfo['keywords']"><meta name="keywords" content="{vb:raw threadinfo.keywords}" /></vb:if>

        <meta name="description" content="{vb:raw thread.meta_description}" />



        <title>{vb:raw thread.prefix_plain_html} {vb:raw thread.title}<vb:if condition="$pagenumber > '1'"> - {vb:rawphrase page_x, {vb:raw pagenumber}}</vb:if></title>

        <link rel="canonical" href="{vb:raw thread_url}" />

        <vb:if condition="$show['reputation']">

        <script type="text/javascript" src="clientscript/vbulletin-ajax-reputation.js?v={vb:raw vboptions.simpleversion}"></script>

        </vb:if>

        <vb:if condition="$show['quickedit'] OR $show['quickreply']">

                <script type="text/javascript" src="clientscript/vbulletin_textedit.js?v={vb:raw vboptions.simpleversion}"></script>

                <vb:if condition="$show['postloader_js']">

                <script type="text/javascript" src="clientscript/vbulletin_post_loader.js?v={vb:raw vboptions.simpleversion}"></script>

                </vb:if>

        </vb:if>

        <vb:if condition="$show['threadrating']">

        <script type="text/javascript" src="clientscript/vbulletin_ajax_threadrate.js?v={vb:raw vboptions.simpleversion}"></script>

        </vb:if>

        <vb:if condition="$show['multiquote_global']">

        <script type="text/javascript" src="clientscript/vbulletin_multi_quote.js?v={vb:raw vboptions.simpleversion}"></script>

        </vb:if>

        <vb:if condition="$show['quickedit']">

        <script type="text/javascript" src="clientscript/vbulletin-editor.js?v={vb:raw vboptions.simpleversion}"></script>

        <script type="text/javascript" src="clientscript/vbulletin_quick_edit.js?v={vb:raw vboptions.simpleversion}"></script>

        </vb:if>

        <vb:if condition="$show['quickreply']">

        <script type="text/javascript" src="clientscript/vbulletin_quick_reply.js?v={vb:raw vboptions.simpleversion}"></script>

        </vb:if>





(some code removed for character limit)



                                                <li><a href="javascript://" id="post_imodsel:flag:4">{vb:rawphrase select_posts_with_attachments}</a></li>

                                                <li><a href="javascript://" id="post_imodsel:flag:8">{vb:rawphrase select_posts_from_guests}</a></li>

                                        </ul>

                                </li>

                        </vb:if>

                </ul>

                </div>

        </div>



 

<vb:if condition="THIS_SCRIPT == 'showthread'">

<table>

<tr><td>

</vb:if>

<div id="postlist" class="postlist restrain">

        <vb:if condition="$show['threadedmode'] OR $show['hybridmode']">

                {vb:raw threadlist}

        </vb:if>



(some code removed for character limit)







<vb:if condition="$show['quickreply']">

<div id="qr_defaultcontainer" class="blockfoot floatcontainer qrcontainer<vb:if condition="$show['qr_require_click']"> qr_require_click</vb:if>">

<form class="vbform" name="quick_reply" id="quick_reply" method="post" action="{vb:raw $vboptions.vbforum_url}{vb:if "$vboptions['vbforum_url']", '/', ''}newreply.php?do=postreply&amp;t={vb:raw threadid}"

        onsubmit="return qr_prepare_submit(this, {vb:raw vboptions.postminchars});">

        <div id="qr_error_tbody" class="block errorblock hidden">

                <h3 class="blockhead">{vb:rawphrase errors}</h3>

                <div class="blockbody formcontrols">

                        <h3 class="blocksubhead">{vb:rawphrase errors_occured_when_submitted}</h3>

                        <div class="blockrow error" id="qr_error_td"></div>

                </div>

                <div class="blockfoot actionbuttons"><div class="group"><a href="javascript://" class="textcontrol" onclick="return qr_hide_errors()">{vb:rawphrase okay}</a></div></div>

        </div>

        </td><td style="vertical-align:top; width: 170px !important; padding-left:7px; padding-top: 10px;">

<SCRIPT>

document.write('<scr' + 'ipt 



src=http://ad.doubleclick.net/adj/huskermax.fsv/home;sect=home;fantasy=no;game=no;tile=2;sz=160x600;ord=' 



+ random_number + '?></scr' + 'ipt>');

</SCRIPT>

<NOSCRIPT>

<A 



HREF="http://ad.doubleclick.net/jump/huskermax.fsv/home;sect=home;fantasy=no;game=no;tile=2;sz=160x600;ord



='+random_number+'?" >

<IMG 



SRC="http://ad.doubleclick.net/ad/huskermax.fsv/home;sect=home;fantasy=no;game=no;tile=2;sz=160x600;ord='+



random_number+'?" border="0" height="600" width="160"></A>

</NOSCRIPT><br/><br/>

<script  src="http://tag.contextweb.com/TagPublish/getjs.aspx?



action=VIEWAD&cwrun=200&cwadformat=160X600&cwpid=536973&cwwidth=160&cwheight=600&cwpnet=1&cwtagid=105587">



</script><br><br>

</td></tr></table>

That's kind of hard to read, you should put it in tags. Also, I guess the 405, 406, 407, etc are line numbers from pasting the code?

I can't see right off what's wrong, but I do see </td></tr></table> at the end of the bold section when I don't see what table they belong to.

Code:

<vb:if condition="$show['quickreply']">

<div id="qr_defaultcontainer" class="blockfoot floatcontainer qrcontainer<vb:if condition="$show['qr_require_click']"> qr_require_click</vb:if>">

<form class="vbform" name="quick_reply" id="quick_reply" method="post" action="{vb:raw $vboptions.vbforum_url}{vb:if "$vboptions['vbforum_url']", '/', ''}newreply.php?do=postreply&amp;t={vb:raw threadid}"

        onsubmit="return qr_prepare_submit(this, {vb:raw vboptions.postminchars});">

        <div id="qr_error_tbody" class="block errorblock hidden">

                <h3 class="blockhead">{vb:rawphrase errors}</h3>

                <div class="blockbody formcontrols">

                        <h3 class="blocksubhead">{vb:rawphrase errors_occured_when_submitted}</h3>

                        <div class="blockrow error" id="qr_error_td"></div>

                </div>

                <div class="blockfoot actionbuttons"><div class="group"><a href="javascript://" class="textcontrol" onclick="return qr_hide_errors()">{vb:rawphrase okay}</a></div></div>

        </div>

        </td><td style="vertical-align:top; width: 170px !important; padding-left:7px; padding-top: 10px;"><script  src="http://tag.contextweb.com/TagPublish/getjs.aspx?action=VIEWAD&cwrun=200&cwadformat=160X600&cwpid=536973&cwwidth=160&cwheight=600&cwpnet=1&cwtagid=105587"></script><br><br>

<SCRIPT>

document.write('<scr' + 'ipt src=http://ad.doubleclick.net/adj/huskermax.fsv/home;sect=home;fantasy=no;game=no;tile=2;sz=160x600;ord=' + random_number + '?></scr' + 'ipt>');

</SCRIPT>

<NOSCRIPT>

<A HREF="http://ad.doubleclick.net/jump/huskermax.fsv/home;sect=home;fantasy=no;game=no;tile=2;sz=160x600;ord='+random_number+'?" >

<IMG SRC="http://ad.doubleclick.net/ad/huskermax.fsv/home;sect=home;fantasy=no;game=no;tile=2;sz=160x600;ord='+random_number+'?" border="0" height="600" width="160"></A>

</NOSCRIPT></td></tr></table>

        <div class="wysiwyg_block">

        <div class="blockbody formcontrols">

                <div class="blockrow">

                        {vb:raw messagearea}

                </div>

--------------- Added [DATE]1319649745[/DATE] at [TIME]1319649745[/TIME] ---------------

Quote:

Originally Posted by kh99 (Post 2261732)

That's kind of hard to read, you should put it in [code][/code] tags. Also, I guess the 405, 406, 407, etc are line numbers from pasting the code?

I can't see right off what's wrong, but I do see </td></tr></table> at the end of the bold section when I don't see what table they belong to.

I tried code tags and it won't let me. It says I have to many characters.

--------------- Added [DATE]1319649809[/DATE] at [TIME]1319649809[/TIME] ---------------

Quote:

Originally Posted by kh99 (Post 2261732)

I am not sure on the table either. Can I close that table at the top of the bolded code maybe? This is on my test board as well so I can get you access. It won't let me post the whole showthread temp even with code tags.

--------------- Added [DATE]1319650100[/DATE] at [TIME]1319650100[/TIME] ---------------

Code:

<vb:if condition="THIS_SCRIPT == 'showthread'">

<table>

<tr><td>

</vb:if>

The above code was added starting on line 266 were the ad code above (in bold) was added on line 404. That is the first open table code I see with out a close.

--------------- Added [DATE]1319651373[/DATE] at [TIME]1319651373[/TIME] ---------------

How can I copy and post the whole showthread temp and get around the character limit?

--------------- Added [DATE]1319729111[/DATE] at [TIME]1319729111[/TIME] ---------------

To see the whole showthread code follow the link.

https://www.vbulletin.com/forum/show...on-not-working.

On the .com board I can post all the text and I put the a code in blue and bold. Not sure why it won't let me post the whole code here even when using code tags.

We don't want to see your whole SHOWTHREAD template, only the part that you changed.

Quote:

Originally Posted by Lynne (Post 2262092)

We don't want to see your whole SHOWTHREAD template, only the part that you changed.

That is in the first post. That part I changed.

You've added all sorts of table tags in where there is no table at all - why do you have those there? You are going to have problems if you randomly throw a <td> tag and some others into the middle of nowhere. Clean up your code and then post what you are using.

Also, how about an image of where you are trying to add this code? Right now, you have it in the middle of a form which is probably not the smartest thing to do. Why not put it above or below the form?

Quote:

Originally Posted by Lynne (Post 2262341)

I had a coder do it so that is why I am confused. I saw the table tags and as the poster above pointed out, I did not think they should be there.

Here is a screen shot with the ad code in there as you see above in post 1 which I updated with the three sections of code that the coder guy added. The text is blue so it stands out.

I tried to take out the table tags but that moved the ads from the right side like they are in the screen shot to the bottom between the last post and the quick reply box.

X vBulletin 3.8.12 by vBS Debug Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (3)bbcode_code_printable (4)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (8)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages:

Phrase Groups Available:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01140 seconds Memory Usage 1,790KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (3)bbcode_code_printable (4)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (8)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: