vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB4 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=252)
-   -   Swapping 'lastpost' for 'dateline' in a php script throws error in tags.php (https://vborg.vbsupport.ru/showthread.php?t=264569)

TWood 06-01-2011 10:41 PM

Swapping 'lastpost' for 'dateline' in a php script throws error in tags.php
 
I've been trying to change the sort order in the tags search results. Lynne suggested a look at the ..\vb\search\searchcontroller\tag.php file, which has this at the bottom:
Code:

                {
                        $sql = "
                                SELECT contenttypeid, tagcontent.contentid, tagcontent.contentid as threadid
                                FROM ". TABLE_PREFIX . "tagcontent as tagcontent
                                WHERE tagid = " . $equals['tag'] . "
                                ORDER BY dateline DESC
                                LIMIT 20000";
                         
                        $rst = $vbulletin->db->query_read($sql);
                        while ($row = $vbulletin->db->fetch_row($rst))
                        {
                                $results[] = $row;
                        }
                }
                return $results;
        }
        private $sorts = array('dateline', 'contenttypeid', 'contentid');
        private $filters = array('tagid', 'contenttypeid', 'dateline');
}

note the part:

FROM ". TABLE_PREFIX . "tagcontent as tagcontent
WHERE tagid = " . $equals['tag'] . "
ORDER BY dateline DESC
LIMIT 20000";

But if I change 'dateline' to 'lastpost' I get this error when I run a tag search, which is based on tags.php in public_html folder:

Code:

Database error in vBulletin 4.1.3:

Invalid SQL:

                                SELECT contenttypeid, tagcontent.contentid, tagcontent.contentid as threadid
                                FROM tagcontent as tagcontent
                                WHERE tagid = 1
                                ORDER BY lastpost DESC
                                LIMIT 20000;

MySQL Error  : Unknown column 'lastpost' in 'order clause'
Error Number  : 1054
Request Date  : Wednesday, May 25th 2011 @ 06:18:12 PM
Error Date    : Wednesday, May 25th 2011 @ 06:18:12 PM
Script        : http://shoutstreet.com/tags.php?tag=78759
Referrer      : http://shoutstreet.com/
IP Address    : 66.68.130.22
Username      : tomwood
Classname    : vB_Database
MySQL Version : 5.0.92-community-log

I'm wondering if I need to change something in the part of ..\vb\search\searchcontroller\tag.php which reads:

Code:

        private $sorts = array('dateline', 'contenttypeid', 'contentid');
        private $filters = array('tagid', 'contenttypeid', 'dateline');

The reason I need to change this is because the default sort order for tags search results is the original date of a post - dateline, whereas I need it to sort on the last post in a thread - lastpost. In the image below, the circled thread has a response that is later than the post date of earlier threads, but is lower on the list. It should be at the top of the list.

https://vborg.vbsupport.ru/external/2011/06/63.png

kh99 06-01-2011 11:03 PM

Maybe try replacing the sql with:

Code:

                        $sql = "
                                SELECT contenttypeid, tagcontent.contentid, tagcontent.contentid as threadid, thread.lastpost AS lastpost
                                FROM ". TABLE_PREFIX . "tagcontent as tagcontent
                                LEFT JOIN ". TABLE_PREFIX . "thread as thread ON (thread.threadid = tagcontent.contentid)
                                WHERE tagid = " . $equals['tag'] . "
                                ORDER BY lastpost DESC
                                LIMIT 20000";


TWood 06-01-2011 11:24 PM

kh99 -

You. Are. Awesome!

Thank you!


All times are GMT. The time now is 04:51 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.00955 seconds
  • Memory Usage 1,727KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_code_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (3)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete