vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- Project Tools (https://vborg.vbsupport.ru/forumdisplay.php?f=266)

- - "Bugs" (https://vborg.vbsupport.ru/showthread.php?t=248797)

ragtek

08-17-2010 07:42 AM

"Bugs"

Because you've copy & pasted the searchclasses, all my found "bugs/codeerrors" from the vb search also can be found in the project tools;)

For example packages..../search/indexcontroller iissue.php line 144 => no $id in the scope, i think it should be $i

packages..../search/indexcontroller/project.php:

PHP Code:


		
			
public function index_id_range($start, $finish)

    {

        global $vbulletin;

        $indexer = vB_Search_Core::get_instance()->get_core_indexer();

        $row = $vbulletin->db->query_read_slave($this->make_query("Project.Projectid BETWEEN " .

            intval($start) . " AND " . intval($finish)));



        while ($row = $vbulletin->db->fetch_row($set))

        {

            $fields = $this->record_to_indexfields($row);

            $indexer->index($fields);

        }

    }

fetch_row should use $row and not $set

There are many more but i have no time for a complete code review;)
You could check the vb bugtracker for my issuereports related to the search.

PitchouneN64ngc

08-18-2010 02:12 AM

I will investigate this but don't expect some fix before 2.2 as PT is not using the vB4 search function actually.

PitchouneN64ngc

10-31-2010 10:05 AM

The "search" function using search.php is actually done and works the same way the actual search.php page (so buggy) in 2.1.2. This is deactivated by default.

You can activate it by changing the value of 'cansearch' from 0 to 1 for contenttype vBProjectTools_IssueNote in the 'contenttype' table.

The system is a copy/paste of forum/thread/post searches into project/issue/issue notes.

All times are GMT. The time now is 06:13 PM.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.00957 seconds Memory Usage 1,719KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)bbcode_php_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (3)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: