vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin.org Site Feedback (https://vborg.vbsupport.ru/forumdisplay.php?f=7)
-   -   split 'DB changes' into 'DB table modifications' and 'DB table additions' (https://vborg.vbsupport.ru/showthread.php?t=229352)

rebelde 12-02-2009 05:21 PM

split 'DB changes' into 'DB table modifications' and 'DB table additions'
 
Hi,

The checkmark beside "DB changes" has been great. It tells me to not even consider a mod, 'cause nothing is allowed messing with my database.

BUT, I would consider some DB changes if they only added tables, instead of modifying vB's tables. By splitting
'DB changes'
into
'DB table modifications' and
'DB table additions'
I will know better which mods I might consider if really useful. :)

An additional benefit is that it would encourage mod developers to create new tables instead of altering existing tables. (We might even try to standardize table names so it will be obvious where they came from. Something like this for a table name: 'vborgFacebookConnect')

Thanks for listening and I hope this is a helpful comment!

Adrian Schneider 12-02-2009 05:22 PM

Agree with the split, but not with the table names. That would mess up code quite a bit, and it's just semantically incorrect for me. Use table comments for that. :)

rebelde 12-02-2009 05:34 PM

Ha! I'll be thrilled if just the first suggestion leads to something.

Paul M 12-02-2009 05:42 PM

Thank you for the suggestion :) but we wont be splitting db changes into two.

rebelde 12-02-2009 05:54 PM

Haha. That was quick. I did plant the idea in your mind, Paul, and maybe a year from now you will like it.

Cheers

Carnage 12-03-2009 10:18 AM

I think it really depends whats modified.

Many of my mods add tables; I try to design to add not edit where ever possible. However sometimes you just need an extra coloumn somewhere.

Provided that the uninstall code reverts the db to the state it was in before the mod was isntalled; I dont see much of an issue.

Dean C 12-03-2009 10:31 AM

You're being overly paranoid. There's no queries in vB3 that I can remember which depend on the total amount of columns in your table. Therefore adding columns will not do any harm at all.


All times are GMT. The time now is 04:40 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.00940 seconds
  • Memory Usage 1,714KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (7)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete