vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)
-   -   read custom profile field. (https://vborg.vbsupport.ru/showthread.php?t=183093)

MessiAz 06-20-2008 07:00 PM
read custom profile field.
 
i coded a php file to read a member's custom profile field.
do you see something bad in my code? is it safe to upload this file to my forum ?

PHP Code:
request
http://xxxxxxxxxxx.com/forum/test.php?user=Tester


$username = $_GET['user'];

$query  = "SELECT userid FROM vb_user WHERE username='" . $username . "'";
$result = mysql_query($query);
if(mysql_num_rows($result) > 0)
{
    $row = mysql_fetch_row($result);
    $userid = $row[0];

    $query = "SELECT usergroupid FROM vb_user WHERE userid='" . $userid . "'";
    $result = mysql_query($query);

    if(mysql_num_rows($result) > 0)
    {
        $row = mysql_fetch_row($result);
        $group = $row[0];

        $query = "SELECT field6 FROM vb_userfield WHERE userid='" . $userid . "'";
        $result = mysql_query($query);

        if(mysql_num_rows($result) > 0)
        {
            $row = mysql_fetch_row($result);
            $serial = $row[0];

            echo "Username: " . $username . "<br>";
            echo "Userid: " . $userid . "<br>";
            echo "group: " . $group . "<br>";
            echo "programid: " . $serial . "<br>";
        }

    }

}

else {

echo "Username: Invalid";
} 

MoT3rror 06-20-2008 07:50 PM
PHP Code:
$username = $_GET['user'];

/*
I suggest changing this query to, then you will only need 1 query then 3

SELECT user.userid, user.usergroupid, userfield.field6
FROM vb_user AS user
LEFT JOIN vb_userfield AS userfield ON (userfield.userid = user.userid)
WHERE user.username = '" . mysql_escape_string($username) . "'"
*/

//added mysql_escape_string to protect against sql injection
$query  = "SELECT userid FROM vb_user WHERE username='" . mysql_escape_string($username) . "'";
$result = mysql_query($query);
if(mysql_num_rows($result) > 0)
{
    $row = mysql_fetch_row($result);
    //this should be userid not 0, you can var_dump for debug if you aren't getting the value you want
    $userid = $row['userid'];

    //why not just select usergroupid from your first query?
    $query = "SELECT usergroupid FROM vb_user WHERE userid='" . $userid . "'";
    $result = mysql_query($query);

    if(mysql_num_rows($result) > 0)
    {
        $row = mysql_fetch_row($result);
        $group = $row[0];

        //you can use a left join with your first query to get this value also
        $query = "SELECT field6 FROM vb_userfield WHERE userid='" . $userid . "'";
        $result = mysql_query($query);

        if(mysql_num_rows($result) > 0)
        {
            $row = mysql_fetch_row($result);
            $serial = $row[0];

            echo "Username: " . $username . "<br>";
            echo "Userid: " . $userid . "<br>";
            echo "group: " . $group . "<br>";
            echo "programid: " . $serial . "<br>";
        }

    }

}

else {

echo "Username: Invalid";
} 

Opserty 06-20-2008 08:22 PM
As MoT3rror suggested, you can cover everything in the single query so you have:
PHP Code:
$username = $_GET['user'];

$sql = "SELECT user.userid, user.usergroupid, userfield.field6
FROM vb_user AS user
LEFT JOIN vb_userfield AS userfield ON (userfield.userid = user.userid)
WHERE user.username = '" . mysql_escape_string($username) . "' LIMIT 1";

$query = mysql_query($sql);
// Do our error checking first...
if(!$query)
{
    echo 'Username: Invalid';
}
else
{
    // Use mysql_fetch_assoc to return [field] => [value] array result
    $data = mysql_fetch_assoc($query);
    
    // Use single quotes if there are no variables in strings
    echo 'Username: ' . $username .'<br>';
    echo 'Userid: ' . $data['userid'] . '<br>';
    echo 'Group: ' . $data['usergroupid'] . '<br>';
    echo 'programid: ' . $data['field6'] . '<br>';
} 
(Credit to MoT3rror for SQL)

Dismounted 06-21-2008 02:35 AM
Using mysql_real_escape_string() is preferable to mysql_escape_string().


All times are GMT. The time now is 04:07 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01658 seconds
  • Memory Usage 1,755KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_php_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (4)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete