vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Member Archives (https://vborg.vbsupport.ru/forumdisplay.php?f=202)
-   -   How to eliminate <br>'s in [code]? (https://vborg.vbsupport.ru/showthread.php?t=1814)

07-16-2000 12:56 PM

When posting something using the code tags then this effectively puts <pre> tags around the text, however because there is a <br> at the end of each line this code ends up double spaced. How can I change things to not print <br>'s when the text is within code tags?

07-19-2000 08:20 AM

*bump*

07-19-2000 03:17 PM

Actually, I would like to know how to get around this as well... I have extensive use of the [ CODE ] tag on my UBB and noticed this problem after doing an import.

-Chris

07-22-2000 12:55 AM

Mark, what version of vB are you on? I know John had changed this in version 1.1.3b3 - although there is one nesting error:

in global.php, around line 262 (in an unhacked one), it now says:

Code:

      $bbcode=str_replace("</code>\r\n","<hr></pre><normalfont></blockquote>",$bbcode);
      $bbcode=str_replace("</code>","<hr></pre><normalfont></blockquote>",$bbcode);

but it should be:
Code:

      $bbcode=str_replace("</code>\r\n","<hr></pre></blockquote><normalfont>",$bbcode);
      $bbcode=str_replace("</code>","<hr></pre></blockquote><normalfont>",$bbcode);

(i.e. nesting error - <normalfont> should come after the closing </blockquote> and not before).

In previous versions the blockquote and pre were in different order, which was less aesthetic and added a redundent space line. But in version 1.1.3b3 John changed it, so I'm not sure why you would have that space at all


(on edit: note that I replace [ /code ] with </code> in the above sections, because otherwise they would render as vB codes on this forum.)

[Edited by bira on 07-21-2000 at 09:57 PM]

07-22-2000 09:55 PM

bira:

Shouldn't the preceding:

Code:

$bbcode=str_replace("<code>\r\n","</normalfont><blockquote><pre><smallfont>code:</smallfont><hr>",$bbcode);
      $bbcode=str_replace("<code>","</normalfont><blockquote><pre><smallfont>code:</smallfont><hr>",$bbcode);

also have the order of normalfont and blockquote reversed?

Parker

[Fixed up the code tags so it didn't parse -Ed]


[Edited by Ed Sullivan on 07-22-2000 at 07:18 PM]

07-23-2000 01:45 AM

nooo, no, no, no. You first close the normalfont tag and then open the blockquote "session". Then, you first close the blockquote "session" and reopen the normalfont tage.

HTML nesting as simple:

<a><b><c> </c></b></a>

or

<a></a><b></b> etc.

You can't have <a><b></a></b> (which is what you're suggesting).

Anyways, it's no biggie.

As for the additional <br>: that space comes from using <blockquote></blockquote> to begin with. It adds a line automatically, which is rendered by the forum as a <br>. If it bothers you THAT much, you can simply remove from the global.php the <blockquote></blockquote> and leave it as <pre></pre> only. This will display the code correctly, it just won't centralize it in the middle of the post.

07-23-2000 01:55 AM

The way that whole thing is written is screwy in that file.

I understanding the nesting bit but it has the </normalfont>
and <blockquote> together and the <normalfont> and </blockquote> together. The previous is with [ code ] and the later is with [ /code ].

The <normalfont> and <blockquote> should go with the [ code ] line and the </blockquote> and </normalquote> should go with the [ /code ] line.

Did I make that as muddy as possible? :)

Parker

07-23-2000 02:08 AM

No nono, I think you want to kill the <normalfont> before the <blockquote> so that the text is displayed in a <pre>-style (sorry, can't think of the word now). Then, just re open it for the rest of the message.

07-23-2000 04:31 PM

Parker, the first </font> is intended to close the normal message font, which is not suitable for prefixed (pre) text. Then, you start the "pre" procedure.

Let me try to illustrate it:

Quote:

user's normal post is in a 'normalfont'.
</ normalfont>
-----------------------------------
Code:

<blockquote>
< smallfont>Code:</ smallfont>
<pre>

The Code

</pre>
</blockquote>

------------------------------------
< normalfont>
back to normalfont post.
Hope that explains the html progress better.

10-16-2000 01:41 PM

This is still a problem, and what was said above does not fix it.

The problem lies here, I believe:

Code:

      // get rid of stray <br> tags in the code - upsets older browsers (IE 4.7
      $codebits=explode("</normalfont><pre><smallfont>code:</smallfont></normal
      list($key,$bbcode)=each($codebits);
      $bbcode=nl2br($bbcode);

      while (list($key,$val)=each($codebits)) {

        $sbbits=explode("</blockquote><hr></pre><normalfont>",$val);
        $newbits=$sbbits[0]."</blockquote><hr></pre><normalfont>".nl2br($sbbits
        $bbcode.="</normalfont><pre><smallfont>code:</smallfont></normalfont><h

      }

When in <pre>, we should not be adding br codes.

-ChadG


All times are GMT. The time now is 01:11 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01148 seconds
  • Memory Usage 1,738KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (5)bbcode_code_printable
  • (1)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete