vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)
-   -   code error on install (https://vborg.vbsupport.ru/showthread.php?t=158215)

lasto 09-19-2007 03:01 PM
code error on install
 
trying to install a hack and getting an error

can anyone spot what is wrong with the code below as its this what is throwing up the error


PHP Code:
if ($_REQUEST['do'] == 'phrase')
{   
    echo "<title>Installing hack</title>
<font face=\"Verdana\" size=\"2\">";
    $findlangs = $db->query_read("SELECT languageid FROM " . TABLE_PREFIX . "language");
    while ($print = $db->fetch_array($findlangs))
    {
    $lang = $print['languageid'];
    $add = $db->query_read("INSERT INTO phrase (languageid, varname, fieldname, text, product, username, dateline, version) VALUES ('$lang', 'nopermission_havenot', 'error', 'return to forumhome. Please turn back to the forums .\r\n<br /><br />Good luck! :)\r\n\r\n<div align=\"{2}\">\r\n<a href=\"index.php\">Home</a>\r\n</div>', 'vbulletin', 'Dominus', '1189940681', '3.6.8'");
    if ($add) 
    {
        echo "Phrase added successfully to the languageid: $lang .";
    }
    }
    echo "<a href='install_ca.php?do=db'>Click here</a> to create database table.";
    echo "</font>";

} 
the error i get is :


PHP Code:
Database error in vBulletin 3.6.8:

Invalid SQL:
INSERT INTO phrase (languageid, varname, fieldname, text, product, username, dateline, version) VALUES ('1', 'nopermission_havenot', 'error', 'Return to forums. Please turn back to the forums <br /><br />Good luck! :)

<div align="{2}">
<a href="index.php">Home</a>
</div>', 'vbulletin', 'Dominus', '1189940681', '3.6.8';

MySQL Error  : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1
Error Number : 1064 

Opserty 09-19-2007 04:33 PM
[sql]
INSERT INTO phrase
(languageid, varname, fieldname, text, product, username, dateline, version)
VALUES
('$lang', 'nopermission_havenot', 'error', 'return to forumhome. Please turn back to the forums .\r\n<br /><br />Good luck! :)\r\n\r\n<div align=\"{2}\">\r\n<a href=\"index.php\">Home</a>\r\n</div>', 'vbulletin', 'Dominus', '1189940681', '3.6.8')
[/sql]
There is a closing bracket missing from the end of the query, (I added it in).

lasto 09-19-2007 04:39 PM
are u sure as i see the closing bracket ?

is really bugging me this as cant track it down

'Dominus', '1189940681', '3.6.8'");

its closed at end of line unless im missing something

Opserty 09-19-2007 04:40 PM
You need one inside the query too. There is a closing bracket missing from the query not the PHP :p
PHP Code:
if ($_REQUEST['do'] == 'phrase')
{   
    echo "<title>Installing hack</title>
<font face=\"Verdana\" size=\"2\">";
    $findlangs = $db->query_read("SELECT languageid FROM " . TABLE_PREFIX . "language");
    while ($print = $db->fetch_array($findlangs))
    {
    $lang = $print['languageid'];
    $add = $db->query_read("INSERT INTO phrase (languageid, varname, fieldname, text, product, username, dateline, version) VALUES ('$lang', 'nopermission_havenot', 'error', 'return to forumhome. Please turn back to the forums .\r\n<br /><br />Good luck! :)\r\n\r\n<div align=\"{2}\">\r\n<a href=\"index.php\">Home</a>\r\n</div>', 'vbulletin', 'Dominus', '1189940681', '3.6.8')");
    if ($add) 
    {
        echo "Phrase added successfully to the languageid: $lang .";
    }
    }
    echo "<a href='install_ca.php?do=db'>Click here</a> to create database table.";
    echo "</font>";

} 
There that should work

lasto 09-19-2007 04:41 PM
can u give me the line with the closign bracket added plz

cheers m8 that worked perfect

if u dont mind this one is thrwoing up an error now - its the last part of the queries

PHP Code:
if ($_REQUEST['do'] == 'db')
{
    echo "<title>Installing </title>
<font face=\"Verdana\" size=\"2\">";
    $db->query_read("CREATE TABLE `covercreditsettings` (
  `id` int(11) NOT NULL auto_increment,
  `credit_pay` int(11) NOT NULL,
  `forums` text collate utf8_unicode_ci NOT NULL,
  PRIMARY KEY  (`id`)
");
   $db->query_read("INSERT INTO `covercreditsettings` (credit_pay, forums) VALUES ('20', '5')");
   echo "Database table has been added.";
   echo "<br />Mod has been installed successfully. Congratulations. :)";
}

?> 
the error is

PHP Code:
Invalid SQL:
CREATE TABLE `covercreditsettings` (
  `id` int(11) NOT NULL auto_increment,
  `credit_pay` int(11) NOT NULL,
  `forums` text collate utf8_unicode_ci NOT NULL,
  PRIMARY KEY  (`id`); 

Opserty 09-19-2007 05:02 PM
Try:
PHP Code:
if ($_REQUEST['do'] == 'db')
{
    echo "<title>Installing </title>
<font face=\"Verdana\" size=\"2\">";
    $db->query_read("CREATE TABLE `covercreditsettings` (
  `id` int(11) NOT NULL auto_increment,
  `credit_pay` int(11) NOT NULL,
  `forums` text collate utf8_unicode_ci NOT NULL,
  PRIMARY KEY  (`id`)
)
");
   $db->query_read("INSERT INTO `covercreditsettings` (credit_pay, forums) VALUES ('20', '5')");
   echo "Database table has been added.";
   echo "<br />Mod has been installed successfully. Congratulations. :)";
} 
I think thats it.

lasto 09-19-2007 05:05 PM
it was correct cheers m8 and thanks for your quick replys

much appreicated

Dismounted 09-20-2007 05:04 AM
What modification are you installing? Not many modifications require external install files these days.


All times are GMT. The time now is 10:29 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01602 seconds
  • Memory Usage 1,756KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (6)bbcode_php_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (8)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete